Skip to content

Prevent window to be called #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoanngueny wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent window to be called #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ Typr._bin = {
}
return s;
},
_tdec : typeof window !== 'undefined' && window["TextDecoder"] ? new window["TextDecoder"]() : null,
_tdec : function() {
Copy link

@lojjic lojjic Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed the type of _tdec from TextDecoder | null to a function, so this would certainly break...?

I think maybe a better approach would be to check for TextDecoder global directly?

_tdec : typeof TextDecoder !== 'undefined' ? new TextDecoder() : null

There's probably also some adjustment to be made in troika-three-text where it tries to hack in worker support.

Copy link
Author

@yoanngueny yoanngueny Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply.

I'm gonna open an issue in the Drei repos.

return typeof window !== 'undefined' && window["TextDecoder"] ? new window["TextDecoder"]() : null;
},
readUTF8 : function(buff, p, l) {
var tdec = Typr._bin._tdec;
if(tdec && p==0 && l==buff.length) return tdec["decode"](buff);
Expand Down