Refine Docs regarding the necessity of ejecting from expo #108
thomas-woehrle
started this conversation in
General
Replies: 1 comment
-
|
hi @thomas-woehrle , thanks for the response, I'm very appreciated. Of course, you can contribute not only library code, but also library document as well here. If anything need to be improved, please let me know! I'm very supportive! Thanks and happy hacking! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
first of all, thanks a lot for this awesome piece of software!
Now, when finding this repository, I checked the installation section and was a bit bummed to see that it says:
However, as it turned out, I didn't need to eject, because I am using expo development builds, which prebuilds automatically if no ios or android directories are available. It might be that this did not work before v1.0.9, because of the declaration of
com.screenguard.ScreenGuardColorActivity(just speculation, I am not an expert).It is awesome that the package does not require ejection from the managed workflow when using development builds and I think making this clear in the documentation would be good, so potential users aren't scared away.
(Disclaimer: I only used the basic register/unregister functionality, maybe ejection is needed for more intricate stuff)
Beta Was this translation helpful? Give feedback.
All reactions