Skip to content

use async emitter from gemini-core instead qemitter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DudaGod wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use async emitter from gemini-core instead qemitter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c2722e
feat: use async emiter from gemini-core instead qemitter
DudaGod Aug 11, 2017
66c4fbf
chore: use ssh-tun with added bluebird
DudaGod Aug 11, 2017
06aa046
fix: tests
DudaGod Aug 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"homepage": "https://github.com/gemini-testing/ssh-tunneler#readme",
"dependencies": {
"lodash": "^4.17.2",
"ssh-tun": "^1.3.0",
"ssh-tun": "gemini-testing/ssh-tun#feat/bluebird",
"urijs": "^1.18.4"
},
"devDependencies": {
Expand All @@ -36,8 +36,8 @@
"chai-as-promised": "^6.0.0",
"eslint": "^3.11.1",
"eslint-config-gemini-testing": "^2.4.0",
"gemini-core": "gemini-testing/gemini-core#feature/emitters",
"mocha": "^3.2.0",
"qemitter": "^1.1.0",
"sinon": "^1.17.6"
}
}
6 changes: 3 additions & 3 deletions test/lib/url-decorator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ describe('url-decorator', () => {
const tunnel = (opts) => _.defaults(opts || {}, {host: 'localhost', port: 8080});

it('should not redefine protocol by default', () => {
const decoratedUri = decorator.create()('https://', tunnel());
const decoratedUri = decorator.create()('https://host', tunnel());

assert.equal(urijs(decoratedUri).protocol(), 'https');
});

it('should use protocol which is specified in options', () => {
const decoratedUri = decorator.create({protocol: 'https'})('http://', tunnel());
const decoratedUri = decorator.create({protocol: 'https'})('http://host', tunnel());

assert.equal(urijs(decoratedUri).protocol(), 'https');
});
Expand Down Expand Up @@ -43,7 +43,7 @@ describe('url-decorator', () => {
it('should apply protocol from options before custom url decorator', () => {
const urlDecorator = sinon.stub();

decorator.create({urlDecorator, protocol: 'https'})('http://', tunnel());
decorator.create({urlDecorator, protocol: 'https'})('http://host', tunnel());

assert.calledWith(urlDecorator, sinon.match(/^https:\/\//));
});
Expand Down
4 changes: 2 additions & 2 deletions test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

const QEmitter = require('qemitter');
const AsyncEmitter = require('gemini-core').AsyncEmitter;

exports.initTool = (events, config) => {
const tool = new QEmitter();
const tool = new AsyncEmitter();

tool.events = events;
tool.config = config;
Expand Down