From 532e663b55e2a04ca95b06da34bfae8e47afe38c Mon Sep 17 00:00:00 2001
From: Onni Hakala <onni@seravo.fi>
Date: Mon, 31 Aug 2015 23:59:53 +0300
Subject: [PATCH 1/3] Added Cache class for using wordpress transients in more
 readable way

---
 Herbert/Framework/cache.php | 64 +++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 Herbert/Framework/cache.php

diff --git a/Herbert/Framework/cache.php b/Herbert/Framework/cache.php
new file mode 100644
index 0000000..cabd5c6
--- /dev/null
+++ b/Herbert/Framework/cache.php
@@ -0,0 +1,64 @@
+<?php namespace Herbert\Framework;
+
+/*
+ * This is wrapper for WordPress transient functions
+ * It uses anonymous functions so 
+ * 
+ * For Example turn this ugly code:
+ *
+    if (false === ( $events = get_transient( $transient ) ) ) {
+        $events = Event::all($start,$end);
+        set_transient( $transient, $result );
+    }
+    return $events;
+
+ * Into:
+ *
+    $events = Cache::store($transient,function() {
+        return Event::all($start,$end);
+    });
+    return $events;
+ */
+    
+class Cache {
+
+    /**
+     * Returns whatever is cached into $key.
+     * Runs $closure and stores it into $key when $closure returns non-empty response
+     *
+     * @param String $key - Key to store the result of the operation
+     *
+     * @param Closure $closure - Anonymous function which is run only when needed
+     *
+     * @return mixed - Returns the result of $closure from cache
+     */
+    public static function store($key,$closure) {
+        if ( self::bypassCache() || false === ( $result = get_transient( $key ) ) ) {
+          $result = $closure();
+          if (!empty($result)) {
+            set_transient( $key, $result );
+          }
+        }
+        return $result;
+    }
+
+    /**
+     * Delete something from the cache
+     *
+     * @param String $key - Key to delete the from cache
+     *
+     * @return mixed - Returns the result of $closure from cache
+     */
+    public static function delete($key) {
+        return delete_transient($key);
+    }
+
+    /**
+     * Check if the request has PRAGMA header set to no-cache
+     *
+     * @return Boolean
+     */
+    public static function bypassCache() {
+         return (isset($_SERVER['HTTP_PRAGMA']) && $_SERVER['HTTP_PRAGMA'] === 'no-cache');
+    }
+}
\ No newline at end of file

From 900fbad30d071038c00007d4280ea6ae0366c972 Mon Sep 17 00:00:00 2001
From: Onni Hakala <onni@seravo.fi>
Date: Tue, 1 Sep 2015 00:00:37 +0300
Subject: [PATCH 2/3] added version constraint for php >=5.4 because Cache uses
 anonymous functions

---
 composer.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/composer.json b/composer.json
index 8ce4feb..81c6136 100644
--- a/composer.json
+++ b/composer.json
@@ -3,6 +3,7 @@
   "description": "Herbert",
   "license": "MIT",
   "require": {
+    "php": ">=5.4.0",
     "twig/twig": "~1.16",
     "illuminate/database": "~5.0",
     "vierbergenlars/php-semver": "~3.0",

From 08f9f59ccbd8f273a5b02165fdfa72e0d7f63ba5 Mon Sep 17 00:00:00 2001
From: Onni Hakala <onni@seravo.fi>
Date: Tue, 1 Sep 2015 00:47:33 +0300
Subject: [PATCH 3/3] switch same php coding style as in Herbert, use strict
 typing for cache for easier debugging

---
 Herbert/Framework/cache.php | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/Herbert/Framework/cache.php b/Herbert/Framework/cache.php
index cabd5c6..fe39d3b 100644
--- a/Herbert/Framework/cache.php
+++ b/Herbert/Framework/cache.php
@@ -1,23 +1,22 @@
 <?php namespace Herbert\Framework;
 
+use Closure;
 /*
  * This is wrapper for WordPress transient functions
  * It uses anonymous functions so 
  * 
  * For Example turn this ugly code:
  *
-    if (false === ( $events = get_transient( $transient ) ) ) {
+    if (false === ( $events = get_transient( 'my-events' ) ) ) {
         $events = Event::all($start,$end);
-        set_transient( $transient, $result );
+        set_transient( 'my-events', $result );
     }
-    return $events;
 
  * Into:
  *
-    $events = Cache::store($transient,function() {
+    $events = Cache::store('my-events',function() {
         return Event::all($start,$end);
     });
-    return $events;
  */
     
 class Cache {
@@ -32,7 +31,8 @@ class Cache {
      *
      * @return mixed - Returns the result of $closure from cache
      */
-    public static function store($key,$closure) {
+    public static function store($key,Closure $closure)
+    {
         if ( self::bypassCache() || false === ( $result = get_transient( $key ) ) ) {
           $result = $closure();
           if (!empty($result)) {
@@ -49,16 +49,18 @@ public static function store($key,$closure) {
      *
      * @return mixed - Returns the result of $closure from cache
      */
-    public static function delete($key) {
+    public static function delete($key)
+    {
         return delete_transient($key);
     }
 
     /**
      * Check if the request has PRAGMA header set to no-cache
      *
-     * @return Boolean
+     * @return bool
      */
-    public static function bypassCache() {
+    public static function bypassCache()
+    {
          return (isset($_SERVER['HTTP_PRAGMA']) && $_SERVER['HTTP_PRAGMA'] === 'no-cache');
     }
 }
\ No newline at end of file