fix(tooltip): allow observing multiple containers with tooltips#2381
Merged
ghiscoding merged 2 commits intomasterfrom Feb 16, 2026
Merged
fix(tooltip): allow observing multiple containers with tooltips#2381ghiscoding merged 2 commits intomasterfrom
ghiscoding merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 195 195
Lines 23959 23959
Branches 8398 8398
=======================================
Hits 23959 23959
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
commit: |
Owner
Author
|
@zewa666 so does that PR cover what you brought up earlier? |
Collaborator
|
yeah I think this should exactly nail it |
Owner
Author
|
Great and BTW you can see it live now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes something I missed in previous comment from @zewa666 I just re-read it and now understood what you really meant, lol. Because earlier I thought you were talking about inner child tooltips (e.g. button+tooltip and inside it an icon+tooltip which wasn't working and I fixed that in PR #2374)... but in reality you just mean watching multiple containers, right?
I simply had to switch from
.querySelector()to.querySelectorAll()and ask the user to provide a CSV string to cover multiple containers. I can do that because of my built-in Binding Event Service that acceptsElement | Element[]for binding and that's it, it just works :)For example: