Add detection for stacked PRs across forks error, and also expired credentials

Co-authored-by: Byron <63622+Byron@users.noreply.github.com>

Author: Copilot

apps/desktop/src/lib/error/knownErrors.ts

@@ -8,7 +8,8 @@ export enum Code {
 	ProjectMissing = 'errors.projects.missing',
 	SecretKeychainNotFound = 'errors.secret.keychain_notfound',
 	MissingLoginKeychain = 'errors.secret.missing_login_keychain',
-	GitHubTokenExpired = 'errors.github.expired_token'
+	GitHubTokenExpired = 'errors.github.expired_token',
+	GitHubStackedPrFork = 'errors.github.stacked_pr_fork'
 }
 
 export const KNOWN_ERRORS: Record<string, string> = {
@@ -34,5 +35,10 @@ With \`seahorse\` or equivalent, create a \`Login\` password store, right click
 	`,
 	[Code.GitHubTokenExpired]: `
 Your GitHub token appears expired, please check your settings!
+	`,
+	[Code.GitHubStackedPrFork]: `
+Stacked pull requests across forks are not supported by GitHub.
+
+The base branch you specified doesn't exist in your fork. When creating a stacked PR, the base branch must exist in the same repository.
 	`
 };

apps/desktop/src/lib/forge/github/ghQuery.ts

@@ -86,7 +86,26 @@ export async function ghQuery<
 			: 'GitHub API error';
 
 		const message = isErrorlike(err) ? err.message : String(err);
-		const code = message.startsWith('Not Found -') ? Code.GitHubTokenExpired : undefined;
+
+		// Check for stacked PR across forks error (base field invalid)
+		let code: string | undefined;
+		if (isErrorlike(err) && 'response' in err) {
+			const response = (err as any).response;
+			if (response?.data?.errors instanceof Array) {
+				const hasInvalidBaseError = response.data.errors.some(
+					(error: any) =>
+						error.resource === 'PullRequest' && error.field === 'base' && error.code === 'invalid'
+				);
+				if (hasInvalidBaseError) {
+					code = Code.GitHubStackedPrFork;
+				}
+			}
+		}
+
+		// Check for expired token
+		if (!code && message.startsWith('Not Found -')) {
+			code = Code.GitHubTokenExpired;
+		}
 
 		return { error: { name: title, message, code } };
 	}

apps/desktop/src/lib/forge/github/githubPrService.test.ts

@@ -1,3 +1,4 @@
+import { Code } from '$lib/error/knownErrors';
 import { GitHub } from '$lib/forge/github/github';
 import { setupMockGitHubApi } from '$lib/testing/mockGitHubApi.svelte';
 import { type RestEndpointMethodTypes } from '@octokit/rest';
@@ -36,4 +37,108 @@ describe('GitHubPrService', () => {
 		const pr = await service?.fetch(123);
 		expect(pr?.title).equal(title);
 	});
+
+	test('should detect stacked PR across forks error', async () => {
+		const mockError = {
+			message: 'Validation Failed',
+			response: {
+				data: {
+					message: 'Validation Failed',
+					errors: [
+						{
+							resource: 'PullRequest',
+							field: 'base',
+							code: 'invalid'
+						}
+					]
+				}
+			}
+		};
+
+		vi.spyOn(octokit.pulls, 'create').mockRejectedValue(mockError);
+
+		try {
+			await service?.createPr({
+				title: 'Test PR',
+				body: 'Test body',
+				draft: false,
+				baseBranchName: 'feature-branch',
+				upstreamName: 'my-branch'
+			});
+			expect.fail('Should have thrown an error');
+		} catch (err: any) {
+			expect(err.code).toBe(Code.GitHubStackedPrFork);
+		}
+	});
+
+	test('should not detect stacked PR error for other validation errors', async () => {
+		const mockError = {
+			message: 'Validation Failed',
+			response: {
+				data: {
+					message: 'Validation Failed',
+					errors: [
+						{
+							resource: 'PullRequest',
+							field: 'title',
+							code: 'missing'
+						}
+					]
+				}
+			}
+		};
+
+		vi.spyOn(octokit.pulls, 'create').mockRejectedValue(mockError);
+
+		try {
+			await service?.createPr({
+				title: 'Test PR',
+				body: 'Test body',
+				draft: false,
+				baseBranchName: 'feature-branch',
+				upstreamName: 'my-branch'
+			});
+			expect.fail('Should have thrown an error');
+		} catch (err: any) {
+			expect(err.code).not.toBe(Code.GitHubStackedPrFork);
+		}
+	});
+
+	test('should detect stacked PR error among multiple validation errors', async () => {
+		const mockError = {
+			message: 'Validation Failed',
+			response: {
+				data: {
+					message: 'Validation Failed',
+					errors: [
+						{
+							resource: 'Issue',
+							field: 'title',
+							code: 'missing'
+						},
+						{
+							resource: 'PullRequest',
+							field: 'base',
+							code: 'invalid'
+						}
+					]
+				}
+			}
+		};
+
+		vi.spyOn(octokit.pulls, 'create').mockRejectedValue(mockError);
+
+		try {
+			await service?.createPr({
+				title: 'Test PR',
+				body: 'Test body',
+				draft: false,
+				baseBranchName: 'feature-branch',
+				upstreamName: 'my-branch'
+			});
+			expect.fail('Should have thrown an error');
+		} catch (err: any) {
+			expect(err.code).toBe(Code.GitHubStackedPrFork);
+		}
+	});
 });