Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Suggested changes no longer match diff #47

@hectorsector

Description

@hectorsector

Bug Report

Current behavior
The starter workflow for Node.js is different (some prior history in #41 and #42), and some of the "copy and paste" workflows throughout the course use the older versions.

Reproduction
Steps to reproduce the behavior in the course:

  1. Join the course
  2. Whenever you see a "copy and paste" workflow, use that.
  3. Notice two bugs when you work this way: commit suggestions no longer match line numbers, and the copy-and-paste workflows are a complete mismatch from what's on the diff.

Expected behavior
The copy-and-paste workflows should match the starter workflow as much as possible.

Possible solution

  • Can replace the text in the copy-and-paste workflows to match starter workflow.
  • Alternatively, can remove the copy-and-paste options.
  • Before suggesting a change, we could test to see if the line we're suggesting on is what we expect

Additional context
Screen Shot 2020-07-30 at 12 28 24 PM

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions