From abd330c0c9136425a78d07366187becc8886efe5 Mon Sep 17 00:00:00 2001 From: Lawrence Hughes Date: Tue, 18 Nov 2025 14:20:50 +0000 Subject: [PATCH 1/3] Updated 'page' query param to minimum of 1 --- .../java/org/grad/secom/core/interfaces/GetSecomInterface.java | 2 +- .../grad/secom/core/interfaces/GetSummarySecomInterface.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java b/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java index afaac04..891b904 100644 --- a/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java +++ b/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java @@ -84,7 +84,7 @@ GetResponseObject get(@QueryParam("dataReference") UUID dataReference, @QueryParam("unlocode") @Pattern(regexp = "[A-Z]{5}") String unlocode, @QueryParam("validFrom") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validFrom, @QueryParam("validTo") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validTo, - @QueryParam("page") @Min(0) Integer page, + @QueryParam("page") @Min(1) Integer page, @QueryParam("pageSize") @Min(0) Integer pageSize); /** diff --git a/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java b/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java index ef3e64b..4706086 100644 --- a/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java +++ b/secom-core/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java @@ -82,7 +82,7 @@ GetSummaryResponseObject getSummary(@QueryParam("containerType") @SecomV1Param C @QueryParam("unlocode") @Pattern(regexp = "[A-Z]{5}") String unlocode, @QueryParam("validFrom") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validFrom, @QueryParam("validTo") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validTo, - @QueryParam("page") @Min(0) Integer page, + @QueryParam("page") @Min(1) Integer page, @QueryParam("pageSize") @Min(0) Integer pageSize); /** From 1873c2510ed76c16b35af9a514ac16c8000ae1f7 Mon Sep 17 00:00:00 2001 From: Lawrence Hughes Date: Tue, 18 Nov 2025 14:27:39 +0000 Subject: [PATCH 2/3] Updated 'page' query param to minimum of 1 --- .../java/org/grad/secom/core/interfaces/GetSecomInterface.java | 2 +- .../grad/secom/core/interfaces/GetSummarySecomInterface.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java b/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java index d823548..a9aea68 100644 --- a/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java +++ b/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSecomInterface.java @@ -83,7 +83,7 @@ GetResponseObject get(@QueryParam("dataReference") UUID dataReference, @QueryParam("unlocode") @Pattern(regexp = "[A-Z]{5}") String unlocode, @QueryParam("validFrom") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validFrom, @QueryParam("validTo") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validTo, - @QueryParam("page") @Min(0) Integer page, + @QueryParam("page") @Min(1) Integer page, @QueryParam("pageSize") @Min(0) Integer pageSize); /** diff --git a/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java b/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java index 8476ce2..84d2e97 100644 --- a/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java +++ b/secom-core-jakarta/src/main/java/org/grad/secom/core/interfaces/GetSummarySecomInterface.java @@ -82,7 +82,7 @@ GetSummaryResponseObject getSummary(@QueryParam("containerType") @SecomV1Param C @QueryParam("unlocode") @Pattern(regexp = "[A-Z]{5}") String unlocode, @QueryParam("validFrom") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validFrom, @QueryParam("validTo") @Parameter(example = "20200101T123000", schema = @Schema(implementation = String.class, pattern = "(\\d{8})T(\\d{6})(Z|\\+\\d{4})?")) @SecomV1Param Instant validTo, - @QueryParam("page") @Min(0) Integer page, + @QueryParam("page") @Min(1) Integer page, @QueryParam("pageSize") @Min(0) Integer pageSize); /** From 8b88a39a4f70f7590472bf4e10613f0f7d413ec5 Mon Sep 17 00:00:00 2001 From: Lawrence Hughes Date: Wed, 19 Nov 2025 16:54:42 +0000 Subject: [PATCH 3/3] Updated version number --- pom.xml | 2 +- secom-core-jakarta/pom.xml | 4 ++-- secom-core/pom.xml | 4 ++-- secom-springboot2/pom.xml | 4 ++-- secom-springboot3/pom.xml | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/pom.xml b/pom.xml index 3395332..4312ef7 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ org.grad.secom secom-parent pom - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT secom-core diff --git a/secom-core-jakarta/pom.xml b/secom-core-jakarta/pom.xml index 1fb8135..98c1d0a 100644 --- a/secom-core-jakarta/pom.xml +++ b/secom-core-jakarta/pom.xml @@ -19,13 +19,13 @@ secom-parent org.grad.secom - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 4.0.0 org.grad.secom secom-core-jakarta - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 9.0.0 diff --git a/secom-core/pom.xml b/secom-core/pom.xml index fe6678f..0f29241 100644 --- a/secom-core/pom.xml +++ b/secom-core/pom.xml @@ -19,13 +19,13 @@ secom-parent org.grad.secom - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 4.0.0 org.grad.secom secom-core - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 2.1.1 diff --git a/secom-springboot2/pom.xml b/secom-springboot2/pom.xml index dfc9a59..e328462 100644 --- a/secom-springboot2/pom.xml +++ b/secom-springboot2/pom.xml @@ -19,13 +19,13 @@ secom-parent org.grad.secom - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 4.0.0 org.grad.secom secom-springboot2 - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 5.3.39 diff --git a/secom-springboot3/pom.xml b/secom-springboot3/pom.xml index 26313a7..15ad402 100644 --- a/secom-springboot3/pom.xml +++ b/secom-springboot3/pom.xml @@ -19,13 +19,13 @@ secom-parent org.grad.secom - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 4.0.0 org.grad.secom secom-springboot3 - 0.0.53-SNAPSHOT + 0.0.54-SNAPSHOT 6.2.8