From 106e529d5d1d2847ade6f3fab47b43dbd4eedc9c Mon Sep 17 00:00:00 2001
From: Wang Cheng-Jun <wangchj04@gmail.com>
Date: Thu, 13 Aug 2015 17:34:51 +0800
Subject: [PATCH 1/3] Update impact_plot.R

when using Date as x-axis, the xintercept used in CreateImpactPlot  should be modified.
---
 R/impact_plot.R | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/R/impact_plot.R b/R/impact_plot.R
index ccc77af..3972ed6 100644
--- a/R/impact_plot.R
+++ b/R/impact_plot.R
@@ -123,9 +123,17 @@ CreateImpactPlot <- function(impact, metrics = c("original", "pointwise",
                        data, fill = "SlateGray2")
 
   # Add pre-period markers
-  xintercept <- CreatePeriodMarkers(impact$model$pre.period,
-                                    impact$model$post.period,
-                                    range(data$t))
+  if (class(data$t) == "Date"){
+    post.period = impact$model$post.period
+    time.range = range(data$t)
+    time.sequence = seq.Date(time.range[1],time.range[2], by = 1)
+    xintercept = as.numeric(time.sequence[ c(post.period[1], post.period[2])])
+  }else{
+    xintercept <- CreatePeriodMarkers(impact$model$pre.period,
+                                      impact$model$post.period,
+                                      range(data$t))
+  }
+  
   q <- q + geom_vline(xintercept = xintercept,
                       colour = "darkgrey", size = 0.8, linetype = "dashed")
 

From a1bc9a8ce5432e88c05e5a2cb37b5540bc6b216f Mon Sep 17 00:00:00 2001
From: Wang Cheng-Jun <wangchj04@gmail.com>
Date: Thu, 13 Aug 2015 21:16:39 +0800
Subject: [PATCH 2/3] Update impact_plot.R

---
 R/impact_plot.R | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/R/impact_plot.R b/R/impact_plot.R
index 3972ed6..b0422e8 100644
--- a/R/impact_plot.R
+++ b/R/impact_plot.R
@@ -125,9 +125,8 @@ CreateImpactPlot <- function(impact, metrics = c("original", "pointwise",
   # Add pre-period markers
   if (class(data$t) == "Date"){
     post.period = impact$model$post.period
-    time.range = range(data$t)
-    time.sequence = seq.Date(time.range[1],time.range[2], by = 1)
-    xintercept = as.numeric(time.sequence[ c(post.period[1], post.period[2])])
+    time.range = unique(data$t)
+    xintercept = as.numeric(time.range[ c(post.period[1], post.period[2])])
   }else{
     xintercept <- CreatePeriodMarkers(impact$model$pre.period,
                                       impact$model$post.period,

From 2385f91d7e8f5115d32c1a0f31fdb7ec7dec3f63 Mon Sep 17 00:00:00 2001
From: Wang Cheng-Jun <wangchj04@gmail.com>
Date: Thu, 13 Aug 2015 21:32:46 +0800
Subject: [PATCH 3/3] Update impact_plot.R

---
 R/impact_plot.R | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/R/impact_plot.R b/R/impact_plot.R
index b0422e8..60ea56e 100644
--- a/R/impact_plot.R
+++ b/R/impact_plot.R
@@ -123,14 +123,14 @@ CreateImpactPlot <- function(impact, metrics = c("original", "pointwise",
                        data, fill = "SlateGray2")
 
   # Add pre-period markers
-  if (class(data$t) == "Date"){
-    post.period = impact$model$post.period
-    time.range = unique(data$t)
-    xintercept = as.numeric(time.range[ c(post.period[1], post.period[2])])
-  }else{
+  post.period = impact$model$post.period
+  if (class(post.period) == "Date"){
     xintercept <- CreatePeriodMarkers(impact$model$pre.period,
                                       impact$model$post.period,
                                       range(data$t))
+  }else{
+    time.range = unique(data$t)
+    xintercept = as.numeric(time.range[ c(post.period[1], post.period[2])])
   }
   
   q <- q + geom_vline(xintercept = xintercept,