dxc_helper.cc compile problems

[normrubin]

I'm having some trouble compiling amber with dxc support -
dxc_helper.cc pulls in dxcapi.h which for me gets three compile errors

it seems to need dxc/support/WinIncludes.h to get definitions
and seems to need functions AddRef and Release defined in class IncludeHandler

I'm trying to figure out if this is my error?
does the dxc support get regularly tested? Has anyone else seen these issues?

[jaebaek]

@normrubin Thank you for reporting this error. I will quickly check it and get back to you.

[jaebaek]

I tried

git clone https://github.com/google/amber
cd amber
./tools/git-sync-deps --with-swiftshader --with-dxc
mkdir -p out/TEST
cmake -GNinja -DAMBER_USE_DXC=True -DAMBER_USE_LOCAL_VULKAN ../..
ninja

I did not get any build error.
Could you please try the above commands?

[normrubin]

i got the failure when compiling on a windows machine
dxcapi pulls in different includes on windows vs linux

Sorry I should have said that this was a windows only issue

I do not see any problems building on linux

[normrubin]

I added to the message on the git hub- My issue shows up windows only

…

On Tue, Feb 2, 2021 at 4:23 PM Jaebaek Seo ***@***.***> wrote: I tried git clone https://github.com/google/amber cd amber ./tools/git-sync-deps --with-swiftshader --with-dxc mkdir -p out/TEST cmake -GNinja -DAMBER_USE_DXC=True -DAMBER_USE_LOCAL_VULKAN ../.. ninja I did not get any build error. Could you please try the above commands? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANARWRIZAXSJ3IJV3DHD2LTS5BULJANCNFSM4W2LMQBQ> .