From 66b75568624c68c58ff052476216959f6df6ace9 Mon Sep 17 00:00:00 2001 From: Mircea Trofin Date: Wed, 17 Dec 2025 15:14:48 -0800 Subject: [PATCH 1/2] [ir2vec] Make the `ir2vec_vocab_path` optional That was probably the intent, given it's tested as such elsewhere. --- compiler_opt/rl/inlining/inlining_runner.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/compiler_opt/rl/inlining/inlining_runner.py b/compiler_opt/rl/inlining/inlining_runner.py index 7ade0992..9afeec5c 100644 --- a/compiler_opt/rl/inlining/inlining_runner.py +++ b/compiler_opt/rl/inlining/inlining_runner.py @@ -39,7 +39,10 @@ class InliningRunner(compilation_runner.CompilationRunner): ir_path, tf_policy_path, default_reward, moving_average_reward) """ - def __init__(self, llvm_size_path: str, ir2vec_vocab_path: str | None, *args, + def __init__(self, + llvm_size_path: str, + ir2vec_vocab_path: str | None = None, + *args, **kwargs): super().__init__(*args, **kwargs) self._llvm_size_path = llvm_size_path From cd0e96e1969d888f9286be76aef385715b0a2978 Mon Sep 17 00:00:00 2001 From: Mircea Trofin Date: Wed, 17 Dec 2025 17:12:06 -0800 Subject: [PATCH 2/2] make them positional --- compiler_opt/rl/inlining/inlining_runner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler_opt/rl/inlining/inlining_runner.py b/compiler_opt/rl/inlining/inlining_runner.py index 9afeec5c..2fbb41a6 100644 --- a/compiler_opt/rl/inlining/inlining_runner.py +++ b/compiler_opt/rl/inlining/inlining_runner.py @@ -40,11 +40,11 @@ class InliningRunner(compilation_runner.CompilationRunner): """ def __init__(self, + *, llvm_size_path: str, ir2vec_vocab_path: str | None = None, - *args, **kwargs): - super().__init__(*args, **kwargs) + super().__init__(**kwargs) self._llvm_size_path = llvm_size_path self._ir2vec_vocab_path = ir2vec_vocab_path