Skip to content
This repository was archived by the owner on Aug 4, 2025. It is now read-only.

Commit c3e428c

Browse files
committed
Fix GoogleUpdateComRegisterShell64.exe does not have a manifest
This CL adds an icon, a manifest, and a version to the exe. #649
1 parent bc6d20f commit c3e428c

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

omaha/goopdate/build.scons

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,28 @@ def BuildCOMRegisterShell64():
116116
],
117117
)
118118

119+
# Add an icon, a manifest, and a version to the exe.
120+
# The resource file used is the same as the one for GoogleUpdate.exe.
121+
# The version resource used is the same as the one for goopdate.dll.
122+
signed_exe_name = 'GoogleUpdateComRegisterShell64'
123+
com_register_shell_res = com_register_shell_env.RES(
124+
'%s.res' % signed_exe_name,
125+
'../google_update/resource.rc')
126+
com_register_shell_env.Depends(com_register_shell_res,
127+
'../google_update/GoogleUpdate.manifest')
128+
com_register_shell_inputs = [
129+
com_register_shell_env.ComponentObject('%s.obj' % signed_exe_name,
130+
'com_register_shell.cc'),
131+
com_register_shell_res,
132+
'$OBJ_ROOT/goopdate/goopdate_version.res',
133+
]
134+
119135
unsigned_exe = com_register_shell_env.ComponentProgram(
120-
prog_name='GoogleUpdateComRegisterShell64_unsigned',
121-
source= [
122-
'com_register_shell.cc',
123-
]
136+
prog_name='%s_unsigned' % signed_exe_name,
137+
source=com_register_shell_inputs
124138
)
125139
signed_exe = com_register_shell_env.SignedBinary(
126-
target='GoogleUpdateComRegisterShell64.exe',
140+
target='%s.exe' % signed_exe_name,
127141
source=unsigned_exe,
128142
)
129143
env.Replicate('$STAGING_DIR', signed_exe)

0 commit comments

Comments
 (0)