Skip to content

Commit 6a39b9f

Browse files
committed
Bump @webgpu/types to 0.1.68
1 parent f793370 commit 6a39b9f

File tree

5 files changed

+30
-9
lines changed

5 files changed

+30
-9
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@types/w3c-image-capture": "^1.0.10",
5151
"@typescript-eslint/eslint-plugin": "^6.9.1",
5252
"@typescript-eslint/parser": "^6.9.1",
53-
"@webgpu/types": "^0.1.66",
53+
"@webgpu/types": "^0.1.68",
5454
"ansi-colors": "4.1.3",
5555
"babel-plugin-add-header-comment": "^1.0.3",
5656
"babel-plugin-const-enum": "^1.2.0",

src/webgpu/api/validation/capability_checks/limits/limit_utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,9 +404,11 @@ export class LimitTestsImpl extends GPUTestBase {
404404
this._adapter = await gpu.requestAdapter();
405405
const limit = this.limit;
406406
// MAINTENANCE_TODO: consider removing this skip if the spec has no optional limits.
407+
// Note: The cast below is required because an optional limit has no entry
408+
// in capability_info.ts kLimitInfoKeys, kLimitInfoDefaults, kLimitInfoData
407409
this.skipIf(
408410
(this._adapter?.limits[limit] === undefined && !!this.limitTestParams.limitOptional) ||
409-
getDefaultLimitsForCTS()[limit] === undefined,
411+
(getDefaultLimitsForCTS() as Record<string, object>)[limit] === undefined,
410412
`${limit} is missing but optional for now`
411413
);
412414
this.defaultLimit = getDefaultLimitForAdapter(this.adapter, limit);

src/webgpu/api/validation/encoding/encoder_open_state.spec.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ const kRenderPassEncoderCommandInfo: {
9898
setScissorRect: {},
9999
setBlendConstant: {},
100100
setStencilReference: {},
101+
setImmediates: {},
101102
beginOcclusionQuery: {},
102103
endOcclusionQuery: {},
103104
executeBundles: {},
@@ -122,6 +123,7 @@ const kRenderBundleEncoderCommandInfo: {
122123
setBindGroup: {},
123124
setIndexBuffer: {},
124125
setVertexBuffer: {},
126+
setImmediates: {},
125127
pushDebugGroup: {},
126128
popDebugGroup: {},
127129
insertDebugMarker: {},
@@ -139,6 +141,7 @@ const kComputePassEncoderCommandInfo: {
139141
} = {
140142
setBindGroup: {},
141143
setPipeline: {},
144+
setImmediates: {},
142145
dispatchWorkgroups: {},
143146
dispatchWorkgroupsIndirect: {},
144147
pushDebugGroup: {},
@@ -298,6 +301,11 @@ g.test('render_pass_commands')
298301
const encoder = t.device.createCommandEncoder();
299302
const renderPass = beginRenderPassWithQuerySet(t, encoder, querySet);
300303

304+
t.skipIf(
305+
command === 'setImmediates' && !('setImmediates' in renderPass),
306+
'setImmediates not supported'
307+
);
308+
301309
const buffer = t.createBufferTracked({
302310
size: 12,
303311
usage: GPUBufferUsage.INDIRECT | GPUBufferUsage.VERTEX,
@@ -456,6 +464,11 @@ g.test('render_bundle_commands')
456464
colorFormats: ['rgba8unorm'],
457465
});
458466

467+
t.skipIf(
468+
command === 'setImmediates' && !('setImmediates' in bundleEncoder),
469+
'setImmediates not supported'
470+
);
471+
459472
if (finishBeforeCommand) {
460473
bundleEncoder.finish();
461474
}
@@ -553,6 +566,11 @@ g.test('compute_pass_commands')
553566

554567
const computePipeline = vtu.createNoOpComputePipeline(t);
555568

569+
t.skipIf(
570+
command === 'setImmediates' && !('setImmediates' in computePipeline),
571+
'setImmediates not supported'
572+
);
573+
556574
const bindGroup = t.createBindGroupForTest();
557575

558576
if (finishBeforeCommand !== 'no') {

src/webgpu/capability_info.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,7 @@ const [kLimitInfoKeys, kLimitInfoDefaults, kLimitInfoData] =
777777
'maxComputeWorkgroupSizeY': [ , 256, 128, ],
778778
'maxComputeWorkgroupSizeZ': [ , 64, 64, ],
779779
'maxComputeWorkgroupsPerDimension': [ , 65535, 65535, ],
780+
// DO NOT ADD OPTIONAL limits here for proposals to the spec. Any limit here is immediately required by all implementations.
780781
} as const];
781782

782783
/**

0 commit comments

Comments
 (0)