Skip to content

Add content editable support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnhidey wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add content editable support #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5294d81
Added support for any element with contenteditable attribute set to t…
Dec 29, 2014
a5e09ae
change the setting from setting innerHTML to innerText to be on the s…
Dec 29, 2014
59d58ed
using innerText instead of innerHTML does not seem to work. The cont…
Dec 29, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ <h2>Elements</h2>
<span class="key">key: k8</span>
<input type="button" name="span1" value="Bind"/>
<input type="button" name="span1" value="Unbind"/>
<span data-key="k8" id="span1">ss</span>
<span data-key="k8" id="span1" contenteditable="true">ss</span>
</div>

<div>
Expand Down Expand Up @@ -127,4 +127,4 @@ <h2>Console</h2>
<!-- filled dynamically -->
</div>
</body>
</html>
</html>
10 changes: 10 additions & 0 deletions src/DataBind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,13 @@
return result;
}

if (el.attributes && el.attributes.contenteditable && el.attributes.contenteditable.value === "true") {
if (isSetter) {
el.innerHTML = newVal;
}
return el.innerHTML;
}

// else assume non-input element
if (isSetter) {
el.innerText = newVal;
Expand Down Expand Up @@ -521,6 +528,9 @@
if (['text', 'textarea'].indexOf(el.type) >= 0) {
return 'input';
}
if (el.attributes && el.attributes.contenteditable && el.attributes.contenteditable.value === "true") {
return 'keyup';
}
}

/**
Expand Down
19 changes: 18 additions & 1 deletion test/DataBind.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,23 @@ describe("DataBind", function() {
expect( $(elem).text() ).toBe( 'value2' );
});

it("should span (inline el) be 2-way bound if it has contenteditable", function() {
var elem = document.getElementById('spanEditable');
$(elem).attr('data-key', 'k1');
var model = {k1: 'value1'};
DataBind.bind(elem, model);
expect( $(elem).text() ).toBe( model.k1 );

model.k1 = 'value2';
expect( $(elem).text() ).toBe( 'value2' );

$(elem).text('changed via elem.');
// simulate as if the change was a user input
fireEvent(elem, 'keyup');
expect( model.k1 ).toBe( 'changed via elem.' );

});

it("should email be 2-way bound", function() {
var elem = document.createElement('input');
$(elem).attr('type', 'email');
Expand Down Expand Up @@ -615,4 +632,4 @@ describe("DataBind", function() {
});


});
});
3 changes: 2 additions & 1 deletion test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
</select>
<div style="display:inline;" data-key="k7" id="div1">dd</div>
<span data-key="k8" id="span1">ss</span>
<span data-key="k8" id="spanEditable" contenteditable="true">ss</span>
<span data-key="k9.k91" id="span2">ss2</span>

<div id="has-children">
Expand All @@ -73,4 +74,4 @@
</div>

</body>
</html>
</html>