feat: add container / tests and release ci

Author: gsdevme

.github/workflows/release.yaml

@@ -0,0 +1,36 @@
+name: goreleaser
+
+on:
+  workflow_dispatch:
+  push:
+    tags:
+      - '*'
+
+jobs:
+  goreleaser:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '^1.17'
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v1
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v1
+      - name: Login to DockerHub
+        uses: docker/login-action@v1
+        with:
+          username: gsdevmebot
+          password: ${{ secrets.DOCKER_HUB }}
+      - name: Run GoReleaser
+        uses: goreleaser/goreleaser-action@v2
+        with:
+          version: latest
+          args: release --rm-dist
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -1 +1,2 @@
-dist/
+dist/
+coverage.out

.goreleaser.yml

@@ -13,6 +13,11 @@ builds:
     goos:
       - linux
       - darwin
+dockers:
+  - image_templates:
+      - "gsdevme/gitops-commit:latest"
+      - "gsdevme/gitops-commit:{{ .Tag }}"
+      - "gsdevme/gitops-commit:v{{ .Major }}"
 archives:
   - replacements:
       darwin: Darwin

Dockerfile

@@ -0,0 +1,7 @@
+FROM scratch
+
+ENV SLACK_SIGNING_SECRET=""
+ENV PORT=8080
+
+ENTRYPOINT ["/gitops-commit"]
+COPY gitops-commit /

Makefile

@@ -4,9 +4,15 @@ default: build;
 fmt:
 	go fmt ./...
 
+lint:
+	 golangci-lint run
+
 tests:
 	go test ./...
 
+coverage:
+	go test -coverprofile=coverage.out ./... && go tool cover -html=coverage.out
+
 run:
 	./dist/gitops-commit_darwin_amd64/gitops-commit
 

go.mod

@@ -4,6 +4,7 @@ go 1.17
 
 require (
 	github.com/go-git/go-git/v5 v5.4.2
+	github.com/google/martian v2.1.0+incompatible
 	github.com/gorilla/mux v1.8.0
 	github.com/slack-go/slack v0.9.5
 	github.com/spf13/cobra v1.2.1

go.sum

@@ -146,6 +146,7 @@ github.com/google/go-cmp v0.5.4/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.5.5 h1:Khx7svrCpmxxtHBq5j2mp/xVjsi8hQMfNLvJFAlrGgU=
 github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
+github.com/google/martian v2.1.0+incompatible h1:/CP5g8u/VJHijgedC/Legn3BAbAaWPgecwXBIDzw5no=
 github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXiIaQGbYVAs8BPL6v8lEs=
 github.com/google/martian/v3 v3.0.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0=
 github.com/google/martian/v3 v3.1.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0=

internal/app/gitops-commit/slackhttp/handler_test.go

@@ -0,0 +1,67 @@
+package slackhttp
+
+import (
+	"encoding/json"
+	"github.com/slack-go/slack"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func Test_handleSlackCommand(t *testing.T) {
+	t.Run("invalid command", func(t *testing.T) {
+		s := &server{}
+		r := &NamedRepositoryRegistry{}
+
+		tests := []struct{
+			name string
+			command string
+			expect string
+		}{
+			{
+				name: "when using missing bits",
+				command: "totally wrong",
+				expect: "Incorrect usage, expected /gitops-commit [command] [name] [tag]",
+			},
+			{
+				name: "when using an invalid command",
+				command: "wrong thing v1.2.3",
+				expect: "Unknown command 'wrong', expected /gitops-commit [command] [name] [tag]",
+			},
+			{
+				name: "when using a valid command ",
+				command: "deploy thing v1.2.3",
+				expect: "Unknown named repository, cannot handle \"thing\", availabe options ()",
+			},
+		}
+
+		for _, tt := range tests {
+			slackCommand := slack.SlashCommand{
+				Text: tt.command,
+			}
+
+			t.Run(tt.name, func(t *testing.T) {
+				rr := httptest.NewRecorder()
+
+				s.handleSlackCommand(r)(rr, slackCommand)
+
+				if c := rr.Code; c != http.StatusOK {
+					t.Errorf("handleSlackCommand() = %v, want %v", c, http.StatusOK)
+				}
+
+				response := make(map[string]interface{})
+				err := json.Unmarshal(rr.Body.Bytes(), &response)
+
+				if err != nil {
+					t.Errorf("handleSlackCommand() invalid json: %s", err)
+				}
+
+				if got, ok := response["text"].(string); ok {
+					if got != tt.expect {
+						t.Errorf("expected '%s', got '%s'", tt.expect, got)
+					}
+				}
+			})
+		}
+	})
+}

internal/app/gitops-commit/slackhttp/middleware.go

@@ -1,6 +1,7 @@
 package slackhttp
 
 import (
+	"github.com/google/martian/log"
 	"github.com/slack-go/slack"
 	"io"
 	"io/ioutil"
@@ -27,6 +28,8 @@ func (s *server) SlackCommandMiddleware(next func(w http.ResponseWriter, s slack
 		if err = verifier.Ensure(); err != nil {
 			w.WriteHeader(http.StatusUnauthorized)
 
+			log.Debugf("unauthorized request")
+
 			return
 		}
 

internal/app/gitops-commit/slackhttp/model.go

@@ -31,6 +31,10 @@ func (c *NamedRepositoryRegistry) Add(name string, r string, f string, n string,
 }
 
 func (c *NamedRepositoryRegistry) findNamedRepository(n string) (*NamedRepository, error) {
+	if c.r == nil {
+		return nil, fmt.Errorf("no named repository found for %s", n)
+	}
+
 	for _, r := range *c.r {
 		if r.Name == n {
 			return &r, nil
@@ -41,6 +45,10 @@ func (c *NamedRepositoryRegistry) findNamedRepository(n string) (*NamedRepositor
 }
 
 func (c *NamedRepositoryRegistry) getNamesFlattened() string {
+	if c.r == nil {
+		return ""
+	}
+
 	var names string
 
 	for _, r := range *c.r {