From b22a57ac335e25095d69465e7e6b402b623cfc8f Mon Sep 17 00:00:00 2001
From: Evan Alter <hadees@users.noreply.github.com>
Date: Thu, 3 Jul 2025 22:51:18 -0500
Subject: [PATCH 1/3] Add script to check macOS defaults compatibility

---
 bin/check-macos-defaults.py | 82 +++++++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)
 create mode 100755 bin/check-macos-defaults.py

diff --git a/bin/check-macos-defaults.py b/bin/check-macos-defaults.py
new file mode 100755
index 00000000000..016d0c35473
--- /dev/null
+++ b/bin/check-macos-defaults.py
@@ -0,0 +1,82 @@
+#!/usr/bin/env python3
+import argparse, re, requests, sys
+
+TESTED_HEADER = '- **Tested on macOS**:'
+
+
+def parse_defaults(file_path):
+    cmds = []
+    regex = re.compile(r'^\s*(?:sudo\s+)?defaults\s+write\s+(\S+)\s+"?([\w.-]+)"?')
+    with open(file_path) as f:
+        for line in f:
+            m = regex.match(line)
+            if m:
+                domain, key = m.groups()
+                cmds.append((domain, key))
+    return cmds
+
+
+def domain_to_folder(domain):
+    if domain.lower() == 'nsglobaldomain':
+        return 'nsglobaldomain'
+    m = re.match(r'com\.apple\.(.+)', domain)
+    if m:
+        return m.group(1).lower()
+    return domain.lower()
+
+
+def fetch_doc(domain, key):
+    folder = domain_to_folder(domain)
+    file = key.lower() + '.md'
+    url = f'https://raw.githubusercontent.com/yannbertrand/macos-defaults/main/docs/{folder}/{file}'
+    resp = requests.get(url)
+    if resp.status_code == 200:
+        return resp.text
+    return None
+
+
+def parse_versions(doc_text):
+    versions = []
+    lines = doc_text.splitlines()
+    for i, line in enumerate(lines):
+        if line.strip().startswith(TESTED_HEADER):
+            for j in range(i+1, len(lines)):
+                ln = lines[j].strip()
+                if ln.startswith('- '):
+                    versions.append(ln[2:].strip())
+                else:
+                    break
+            break
+    return versions
+
+
+def main():
+    parser = argparse.ArgumentParser(description='Check macOS defaults compatibility.')
+    parser.add_argument('macos_file', help='Path to .macos file')
+    parser.add_argument('version', help='macOS version name, e.g., Ventura')
+    args = parser.parse_args()
+
+    cmds = parse_defaults(args.macos_file)
+    if not cmds:
+        print('No defaults commands found')
+        return
+
+    unsupported = []
+    for domain, key in cmds:
+        doc = fetch_doc(domain, key)
+        if not doc:
+            unsupported.append((domain, key, 'No doc found'))
+            continue
+        versions = parse_versions(doc)
+        if args.version not in versions:
+            unsupported.append((domain, key, 'Version not listed'))
+
+    if unsupported:
+        print('Commands potentially unsupported on', args.version)
+        for domain, key, reason in unsupported:
+            print(f'  {domain} {key} - {reason}')
+    else:
+        print('All commands supported for', args.version)
+
+if __name__ == '__main__':
+    main()

From 7de37f18691768cdf8a62af2bf8c601b11e62a7a Mon Sep 17 00:00:00 2001
From: Evan Alter <hadees@users.noreply.github.com>
Date: Thu, 3 Jul 2025 22:56:36 -0500
Subject: [PATCH 2/3] Run defaults checker in CI

---
 .github/workflows/tests.yml | 4 ++++
 bin/check-macos-defaults.py | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 2ff34bb2d72..14713c16bf5 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -23,3 +23,7 @@ jobs:
         run: brew install bats-core
       - name: Run tests
         run: bats tests
+      - name: Install dependencies for defaults check
+        run: pip3 install requests
+      - name: Check macOS defaults compatibility
+        run: ./bin/check-macos-defaults.py .macos Sonoma
diff --git a/bin/check-macos-defaults.py b/bin/check-macos-defaults.py
index 016d0c35473..ab11e622201 100755
--- a/bin/check-macos-defaults.py
+++ b/bin/check-macos-defaults.py
@@ -75,8 +75,10 @@ def main():
         print('Commands potentially unsupported on', args.version)
         for domain, key, reason in unsupported:
             print(f'  {domain} {key} - {reason}')
+        sys.exit(1)
     else:
         print('All commands supported for', args.version)
+        sys.exit(0)
 
 if __name__ == '__main__':
     main()

From 3f0154f7b4a0c70c4f866915f1c0dadd3d8cf6c3 Mon Sep 17 00:00:00 2001
From: Evan Alter <hadees@users.noreply.github.com>
Date: Thu, 3 Jul 2025 22:59:33 -0500
Subject: [PATCH 3/3] Fix requests install in CI

---
 .github/workflows/tests.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 14713c16bf5..f094ed597d0 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -24,6 +24,6 @@ jobs:
       - name: Run tests
         run: bats tests
       - name: Install dependencies for defaults check
-        run: pip3 install requests
+        run: pip3 install --break-system-packages requests
       - name: Check macOS defaults compatibility
         run: ./bin/check-macos-defaults.py .macos Sonoma