Image urls are incorrect when using a different disk

[chinleung]

The images are unable to preview when you use a disk different from the default one.

For instance:

ArrayImages::make('Images')->disk('s3')->path('uploads');

And your default disk is set to local. It is trying to load the image url from the local disk instead of the s3 disk.

[tzkmx]

Maybe is a bit late to reply to this, but in case someone else is stuck with this bug, the issue is in this line:

array-images/src/FieldController.php

Line 30 in 01a13c9

'url' => Storage::url($savedImage)

but it is for the "stable" v1.1 of the package you get with composer default config (the packages you get from packagist.org).

Actually in master is fixed:

array-images/src/FieldController.php

Line 30 in 3d643b4

'url' => Storage::disk($disk)->url($savedImage),

I wonder if someone should continue the development of the package or at least show a way to patch the package with the latest fixes.

[tzkmx]

It is possible to apply this patch already in the repo but not in packagist, through use of composer-patches. I've applied it using this in my composer.json:

    "extra": {
        "patches": {
            "halimtuhu/array-images": {
                "issue-12:controller not uses disk": "https://github.com/halimtuhu/array-images/commit/7a98fc42e03371d6713d535eb09f42029648b271.patch"
            }
        }
    }

cc @chinleung