Type errors

[udondan]

Hi @hanwencheng,

I'm failing to get your package working. I tried the simplest examples from your readme but there seem to be some type problems. This is my code:

But you see the type errors:

It only accepts 2 and 3.

Then I tried to give it a shot with the defaults, but neither that I can get to work. This:

Will just error out with

TypeError: common_substrings_1.default is not a function

Any idea what's going on?

Thanks,
Daniel

[udondan]

The numbers are fixed here: https://github.com/udondan/CommonSubstrings/blob/d4e29bece909642643a33c95bd219d6fa1b30ba6/lib/index.d.ts#L15-L16

[maiasmith]

I'm having the same issue.

[milahu]

this is not released on npm, so install from git

pnpm rm common-substrings

pnpm i common-substrings@github:hanwencheng/CommonSubstrings#8ee403368c3df68f95b6f9d79acdcae5093091d5

[udondan]

I also released it under my namespace: https://www.npmjs.com/package/@udondan/common-substrings

@hanwencheng would be great if the latest state could be published

[sneko]

Note that typings say minOccurrence can be undefined but it's wrong. If nothing is specified it will never return patterns (I would have think 2 would be the default).