Please, Upgrade armon/go-metrics to hashicorp/go-metrics

[peczenyj]

The package armon/go-metrics was renamed to hashicorp/go-metrics

however, I need to add replace directives in my go.mod files to keep the vendors updated.

can we just update the dependencies and release again?

[Dentrax]

Just hit this issue. I was wondering if there are any updates on this?

cc @badrabubker

[rboyer]

Quoting @jmurret's reply on a related PR:

Hi all, we will post a more detailed thread on why this is complicated, but the short gist is that this change has to be consistently updated across the dependency chains of libraries used in an application. go-metrics relies on a singleton sink in global state. If any applications have a mix of armon metrics and hashicorp due to underlying dependencies not aligning on only one of them, metrics will be split among different sinks in the global state.
This change has to be coordinated with changing and releasing this dependency across multiple libraries and applications in a thoughtful way. This PR is taking longer than expected due to the prioritization and coordination of those efforts to ensure a smooth transition. Thank you for your patience and understanding.

[godcong]

hashicorp/go-metrics updated several versions... You can't update this one, or you'll get an error.

go: github.com/armon/go-metrics@v0.5.3: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics
        trying github.com/armon/go-metrics@v0.5.2
go: github.com/armon/go-metrics@v0.5.2: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics
        trying github.com/armon/go-metrics@v0.5.1
go: github.com/armon/go-metrics@v0.5.1: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics
        trying github.com/armon/go-metrics@v0.5.0
go: github.com/armon/go-metrics@v0.5.0: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics
        trying github.com/armon/go-metrics@v0.4.2
go: github.com/armon/go-metrics@v0.4.2: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics
        restoring github.com/armon/go-metrics@v0.4.1

[godcong]

Can move the old version back to github.com/armon/go-metrics
When I update the package, the update fails.
I don't really care which package I use, but it always makes me think my code is wrong.

[dharmil-iv]

This change is breaking https://github.com/mennanov/limiters. I am not able to import this library into my codebase. Go is throwing conflict error because of this dependency.

Command: go get github.com/mennanov/limiters@v1.13.3

Result:
go: github.com/mennanov/limiters imports github.com/hashicorp/consul/api imports github.com/hashicorp/serf/coordinate imports github.com/hashicorp/go-metrics/compat imports github.com/armon/go-metrics: github.com/armon/go-metrics@v0.5.4: parsing go.mod: module declares its path as: github.com/hashicorp/go-metrics but was required as: github.com/armon/go-metrics

If anyone can help me fix this issue, I would greatly appreciate it.

Issue

I’m unable to import this library due to a dependency conflict.

Command

go get github.com/mennanov/limiters@v1.13.3

Error

go: github.com/mennanov/limiters imports
        github.com/hashicorp/consul/api imports
        github.com/hashicorp/serf/coordinate imports
        github.com/hashicorp/go-metrics/compat imports
        github.com/armon/go-metrics: github.com/armon/go-metrics@v0.5.4: parsing go.mod:
        module declares its path as: github.com/hashicorp/go-metrics
                but was required as: github.com/armon/go-metrics

Notes

• The problem seems to come from a mismatch between github.com/armon/go-metrics and github.com/hashicorp/go-metrics.
• Because of this, limiters cannot be imported without manual fixes.

Request

Could this dependency be updated or fixed?
Any guidance on a workaround would be very helpful.

[peczenyj]

for months we have to use a mod rewrite on this dependency, like this @dharmil-iv

on go.mod

replace github.com/armon/go-metrics v0.5.4 => github.com/hashicorp/go-metrics v0.5.4

[godcong]

The issue lies with the project's package name, which is github.com/hashicorp/go-metrics instead of github.com/armon/go-metrics.
I made a temporary fix by modifying the package name to resolve this. You can use:

replace github.com/armon/go-metrics v0.5.4 => github.com/origadmin/go-metrics v0.5.4

[dharmil-iv]

Description

When I try to import this library, I encounter an issue related to the underlying serf dependency.

Specifically, attempting to use the following go.mod replace directive does not resolve the error:

replace github.com/armon/go-metrics v0.5.4 => github.com/origadmin/go-metrics v0.5.4

Error Output

go mod tidy                                                                                                      
go: github.com/hashicorp/go-metrics@v0.5.4 used for two different module paths (github.com/armon/go-metrics and github.com/hashicorp/go-metrics)

Additional Info

• The issue appears to stem from the serf library as a dependency.
• The conflict between module paths for go-metrics persists despite the replace directive.

Steps to Reproduce

1. Attempt to import https://github.com/mennanov/limiters library in a Go project
2. Add the replace directive to your go.mod
3. Run go mod tidy

Expected Behavior

The replace directive should resolve the dependency conflict.

Actual Behavior

The error above is thrown and the module cannot be imported cleanly.

References

• Related issue: Migrate from armon/go-metrics to hashicorp/go-metrics for Dependency Compatibility mennanov/limiters#164

---

Any guidance on how to resolve or work around this would be appreciated.