From c4dd6a9df8412e854bde574461d1309511d2ad11 Mon Sep 17 00:00:00 2001 From: demojie <1426134543@qq.com> Date: Tue, 11 Feb 2020 20:02:48 +0800 Subject: [PATCH] Fix memory leak by setting position of popped element to null. --- src/main/java/com/github/hcsp/Stack.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/github/hcsp/Stack.java b/src/main/java/com/github/hcsp/Stack.java index db23e86..1491b9d 100644 --- a/src/main/java/com/github/hcsp/Stack.java +++ b/src/main/java/com/github/hcsp/Stack.java @@ -21,7 +21,11 @@ public Object pop() { if (size == 0) { throw new EmptyStackException(); } - return elements[--size]; + int currentIndex = --size; + Object element = elements[currentIndex]; + // Release the reference + elements[currentIndex] = null; + return element; } /**