Skip to content

[Windows] [CMake] ZLib-Version mismatch #241

@dbaudio-bernhardfiedler

Description

You kindly provide the prebuilt zlib-1.3.1 within the subdirectory windows/third-party/zlib-1.3.1 - but in the src/CMakeLists.txt, the target_include_directories is still referencing the old 1.2.11 version:

${PROJECT_SOURCE_DIR}/windows/third-party/zlib-1.2.11/include/)

AND there is even a duplication of some cmake code, which is problematic. The block of lines 6 to 21 (

if(NOT MSVC)
) is almost identical with the following block which seems more elaborated. My suggestion would be to remove the first block (L6-21).

This breaks using libmysofa as a submodule. Would be great if you could fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions