From d722c40d6e176c8ece698348298cd57dcb7482b9 Mon Sep 17 00:00:00 2001 From: Tle Ekkul Date: Tue, 23 Apr 2019 20:24:02 +0700 Subject: [PATCH 1/2] Return false when response from facebook is not 200 --- Cpp/odin/facebook.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Cpp/odin/facebook.cpp b/Cpp/odin/facebook.cpp index 77d460f..df7c5da 100644 --- a/Cpp/odin/facebook.cpp +++ b/Cpp/odin/facebook.cpp @@ -46,6 +46,9 @@ bool odin::facebook::is_user_authenticated( fb_url.query(qs); fostlib::http::user_agent ua(fb_url); auto response = ua.get(fb_url); + if (response->status() != 200) { + return false; + } auto response_data = fostlib::coerce( fostlib::coerce(response->body()->data())); fostlib::json body = fostlib::json::parse(response_data); From b3163d0b14878824c8234fc333783bbeb8164242 Mon Sep 17 00:00:00 2001 From: Tle Ekkul Date: Tue, 23 Apr 2019 20:24:27 +0700 Subject: [PATCH 2/2] no need to put it in the Client_ID field --- Cpp/odin/facebook.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cpp/odin/facebook.cpp b/Cpp/odin/facebook.cpp index df7c5da..6c14b1c 100644 --- a/Cpp/odin/facebook.cpp +++ b/Cpp/odin/facebook.cpp @@ -59,7 +59,7 @@ bool odin::facebook::is_user_authenticated( fostlib::json odin::facebook::get_user_detail(f5::u8view user_token) { fostlib::url base_url(odin::c_facebook_endpoint.value()); fostlib::url::filepath_string api{"/me"}; - auto fb_apps = odin::c_facebook_apps.value()["Client_ID"]; + auto fb_apps = odin::c_facebook_apps.value(); for (const auto fb_app : fb_apps) { const auto app_token = get_app_token( fostlib::coerce(fb_app["app_id"]),