Issue with "destroy" cycle

[fazedesigns]

Hi, this is so great you are keeping cycle2 alive!

I am having an issue when I destroy a slideshow.
I am trying to change the carousel visible count on different size screens:

var width = $(window).width(); // Checking size again after window resize
if ( width < 768 ) {
$('.carousel_logos').cycle( "destroy" );
$('.logo_block .carousel_logos').cycle({
carouselVisible : 2,
autoHeight : 0
});
}

I am then getting this error:

jQuery.Deferred exception: this.varType is not a function. (In 'this.varType( $._data )', 'this.varType' is undefined) (2)

line 990
var clean = (this.varType($._data) === 'function') ? $._data : $.noop;

Is this an issue? Or am I doing this wrong?
Thanks!

[iam-sysop]

It appears that is a bug introduced when I attempted to remove a deprecated jQuery function from the original code.

Please check the version you are using to be sure - as well as the version of jQuery you might be running on just to be sure, and I will look at what I did wrong in the code!

To mitigate if this is the case, attempting to use the 2.1.6b version on the releases page MIGHT resolve the issue -- https://github.com/thecarnie/cycle2/releases/tag/2.1.6b (but it will require jQuery-Migrate if you are running on jQuery 3+

[fazedesigns]

I changed to 2.1.6b and added jQuery Migrate. I am using jQuery 3.5.1 too.
It is now showing different errors.
It seems the "destroy" worked but will not re-build the slider.

jQuery.Deferred exception: undefined is not an object (evaluating 'opts._carouselWrap.remove') (2)

Carousel Extension - line 265
opts._carouselWrap.remove();

[iam-sysop]

Ok - so it's most likely not actually the new mitigations in 2.1.6c but an issue with the carousel plugin itself.

If I remember right, I had an issue with Destroy and Init in the past. Let me look at a site I have and see what I did for that -- maybe there's a fix hidden in there for the code to bring it in line.

Thanks a lot for your help sorting through this!

[fazedesigns]

Your welcome!

I just tried this with 2.1.6b and there are no errors but the cycle does not Init after destroying.

$('.block_hero .cycle-slideshow').cycle( "destroy" );
$('.block_hero .cycle-slideshow').cycle({
timeout : 700
});

This is not using carousel so I am not sure if that helps.

[fazedesigns]

Hi, Did you happen to find that fix for Init after Destroy?
Thanks!

[iam-sysop]

I have been working through changes made to the code but have not located the direct issue. I am wondering if by some reason part of the code is not present in your download. In the meantime I am re-examining the built files and investigating further if there is an issue with the needed function Destroy() not being included properly in the build. Destroy() is part of the "Command" plugin --

…

On Mon, Apr 26, 2021 at 2:22 PM fazedesigns ***@***.***> wrote: Hi, Did you happen to find that fix for Init after Destroy? Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXWENULLG4GJ5CBXWFIWU3TKW4QHANCNFSM42TSNKCQ> .

[iam-sysop]

Re: init not working after destroy - this issue I have ran into before - I am hunting through previous websites I have used the plugin on because I wrote a work-around into that site, and it needs to be included in the plugin (or at least documentation).

I apologize for the delayed fix -- there have been a couple "life curveballs" thrown at me over the last couple weeks but things are starting to get back to normal.

[flyt3dev]

@iam-sysop was there ever a fix for the destroy issue?