From 54297a6532cefda2269f4aaf6b8ab132a824cd89 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 21 Dec 2022 04:06:18 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- dataset/cifar.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/dataset/cifar.py b/dataset/cifar.py index b27ae40..272c42c 100644 --- a/dataset/cifar.py +++ b/dataset/cifar.py @@ -188,7 +188,26 @@ def download(self): # extract file with tarfile.open(os.path.join(self.root, self.filename), "r:gz") as tar: - tar.extractall(path=self.root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=self.root) def extra_repr(self): return "Split: {}".format("Train" if self.train is True else "Test")