ImageFill + splitview: sometimes vertical pictures are cropped instead of showin in split view

[ikitzmann]

Version

v1.0.30.0 (image: ghcr.io/immichframe/immichframe:latest)

Deployment Method

Web (Docker)

Description

I have the following combination of settings in my compose.yaml:

      ImageFill: "true"
      Layout: "splitview"

I use it on a horizontal screen.

Expected result

1. If it is a landscape image: zoom to fill the entire screen, crop if necessary
2. If it is a portrait/vertical image: Switch to split view, display two portrait images side by side and zoom each side to fill the entire side, crop if necessary

What is happening

1. works as intended
2. Quite often, the portrait images are not shown in split view and are then cropped to fill the screen. For portrait images, this crops too much from the images, so that sometimes e.g. only the nose and mouth of a person is visible. This does look very bad.

If I disable ImageFill, then the effect is not as bad (because I see the complete portrait images), but then I always do have the blurred borders - even for landscape images (because my screen does not match the aspect ratio of the images).

Can the split view be enforced for portrait images? Why are portrait images are sometimes shown in split view and sometimes not (even the same image shows up in both split and non-split view)?

If you need any more information, please let me know.

Reproduction

Set the settings as described above. Then click to show the next image some times. Quickly, a portrait image in single, cropped view does come up.

Expectations

No response

Configuration

Logs

Pre-Submission Checklist

• This is a bug report and not a feature request

• I have provided all of the required information to reproduce the bug (config, logs, etc.)

• I have checked for related issues and checked the documentation

[ikitzmann]

Alternative idea: do only fill if the image orientation matches the screen orientation (only fill horizontal images in horizontal frames). Split view woud be two vertical frames.

[JW-CH]

Alternative idea: do only fill if the image orientation matches the screen orientation (only fill horizontal images in horizontal frames). Split view woud be two vertical frames.

I was thinking about something like this. The viewing client can decide how the split should display images (horizontal split or vertical split) according to its orientation.

[ikitzmann]

I just found out about https://github.com/damongolding/immich-kiosk - which already does work with two vertical pictures + cover-fill without any problems. It even has more functionality (like setting some parameters as the album per URL - perfect for serving different frames from the same instance).
So for me it looks like it is the more fitting app. The first tests look very promising. I will give it a go over the weekend and see if I find any blocking issues for me.

This means: this bug/feature request might still be a valid one for the project, but I will most likely switch to immich-kiosk. At least for now. I would like to avoid any work that could be used for other users needs.