From fe491bbf56d2ff092bdf03726211f64343afe029 Mon Sep 17 00:00:00 2001 From: Ricky McAlister Date: Sat, 11 Jan 2025 16:01:57 +1100 Subject: [PATCH] Fix: Leverage Solidity's built-in overflow/underflow checks (Solidity 0.8.0) to avoid any potential overflows and revert the transaction if one occurs --- contracts/token/erc721/abstract/ImmutableERC721Base.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/token/erc721/abstract/ImmutableERC721Base.sol b/contracts/token/erc721/abstract/ImmutableERC721Base.sol index d93a61a4..36c1a764 100644 --- a/contracts/token/erc721/abstract/ImmutableERC721Base.sol +++ b/contracts/token/erc721/abstract/ImmutableERC721Base.sol @@ -241,7 +241,7 @@ abstract contract ImmutableERC721Base is OperatorAllowlistEnforced, MintingAcces } // slither-disable-next-line costly-loop - _totalSupply = _totalSupply + mintRequest.tokenIds.length; + _totalSupply += mintRequest.tokenIds.length; for (uint256 j = 0; j < mintRequest.tokenIds.length; j++) { _mint(mintRequest.to, mintRequest.tokenIds[j]); } @@ -260,7 +260,7 @@ abstract contract ImmutableERC721Base is OperatorAllowlistEnforced, MintingAcces _safeMint(mintRequest.to, mintRequest.tokenIds[j]); } // slither-disable-next-line costly-loop - _totalSupply = _totalSupply + mintRequest.tokenIds.length; + _totalSupply += mintRequest.tokenIds.length; } /**