Skip to content

Conversation

@osenan
Copy link

@osenan osenan commented Dec 19, 2025

Pull Request

Adding missing unit test listed in here #288
The added test do not fail for me. However, one tests of the package fail locally.
To review, expect the CI to no have any failures with tests.
Individual test can be checked with devtools::load_all() and testthat::test_file

@osenan osenan requested a review from a team December 19, 2025 14:41
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@osenan
Copy link
Author

osenan commented Dec 19, 2025

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/call_utils.R                      163     125  23.31%   19-28, 65, 67, 69, 102-345, 405
R/check_selector.R                   33       0  100.00%
R/choices_labeled.R                 157      27  82.80%   67, 73, 78, 85, 101, 218-222, 226-231, 354-355, 357, 363, 390-397
R/choices_selected.R                 81       3  96.30%   212, 218, 274
R/column_functions.R                  3       1  66.67%   18
R/data_extract_datanames.R           30       0  100.00%
R/data_extract_filter_module.R      105      47  55.24%   95-108, 110-111, 113-130, 146-165
R/data_extract_module.R             305      67  78.03%   139, 144, 161, 164-169, 171, 190-193, 223-269, 507, 512, 688, 699-700, 778-783
R/data_extract_read_module.R        137       7  94.89%   34, 39-41, 43, 138, 155
R/data_extract_select_module.R       32      18  43.75%   29-46
R/data_extract_single_module.R       60       2  96.67%   30, 43
R/data_extract_spec.R                32       0  100.00%
R/delayed_choices.R                  34       6  82.35%   86, 95-99
R/filter_spec.R                     186       1  99.46%   279
R/format_data_extract.R              16       1  93.75%   48
R/get_dplyr_call.R                  297       0  100.00%
R/get_merge_call.R                  278      29  89.57%   31-37, 48, 214-223, 388, 404-416
R/input_checks.R                     11       2  81.82%   15-16
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  137       6  95.62%   122, 254-258
R/merge_expression_module.R          60      11  81.67%   160-165, 183, 359-364
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       4  75.00%   76-79
R/resolve.R                         115      45  60.87%   46, 180-286
R/select_spec.R                      64       8  87.50%   98, 178-185
R/utils.R                            37      24  35.14%   31-44, 172-185
R/zzz.R                               3       3  0.00%    2-4
TOTAL                              2417     437  81.92%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  -------
R/choices_selected.R              0      -8  +9.88%
R/column_functions.R              0      -2  +66.67%
R/data_extract_datanames.R        0      -8  +26.67%
TOTAL                             0     -18  +0.74%

Results for commit: 2362822

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Unit Tests Summary

  1 files   25 suites   7s ⏱️
201 tests 201 ✅ 0 💤 0 ❌
709 runs  709 ✅ 0 💤 0 ❌

Results for commit 2362822.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
column_functions 👶 $+0.01$ $+2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
choices_selected 👶 $+0.01$ if_we_call_add_no_selected_choices_we_add_no_selection
choices_selected 👶 $+0.01$ no_selected_as_NULL_returns_NULL_if_word_is_within_no_selected
column_functions 👶 $+0.01$ get_dataset_prefixed_col_names_returns_vector_of_columns
column_functions 👶 $+0.00$ get_dataset_prefixed_col_names_returns_vector_of_multiple_columns
data_extract_datanames 👶 $+0.01$ data_extract_datanames_returns_FALSE_in_multiple_datasets
data_extract_datanames 👶 $+0.01$ data_extract_datanames_returns_TRUE_in_single_dataset
data_extract_datanames 👶 $+0.01$ datanames_input_gets_the_data_names_provided_to_module

Results for commit 471e3d3

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants