Build errors building DPTF/Linux

[GeniusTechnoMystic]

I am using Ubuntu Noble Numbat 24.04 with cmake v3.28.3-1build7 and make 4.3-4.1build2.

Build errors:

[ 50%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ArbitratorActiveControlCapabilities.cpp.o
In file included from /home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableBase.h:23,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/ThermalRelationshipTable.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/CallbackScheduler.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/CallbackScheduler.cpp:19:
/home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableEntryBase.h:58:22: error: ‘virtual Bool RelationshipTableEntryBase::operator==(const RelationshipTableEntryInterface&) const’ was hidden [-Werror=overloaded-virtual=]
   58 |         virtual Bool operator==(const RelationshipTableEntryInterface& baseEntry) const override;
      |                      ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/ThermalRelationshipTable.h:23:
/home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/ThermalRelationshipTableEntry.h:39:14: note:   by ‘Bool ThermalRelationshipTableEntry::operator==(const ThermalRelationshipTableEntry&) const’
   39 |         Bool operator==(const ThermalRelationshipTableEntry& trtEntry) const;
      |              ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableBase.h:23,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.cpp:19:
/home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableEntryBase.h:58:22: error: ‘virtual Bool RelationshipTableEntryBase::operator==(const RelationshipTableEntryInterface&) const’ was hidden [-Werror=overloaded-virtual=]
   58 |         virtual Bool operator==(const RelationshipTableEntryInterface& baseEntry) const override;
      |                      ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:23:
/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.h:40:14: note:   by ‘Bool ActiveRelationshipTableEntry::operator==(const ActiveRelationshipTableEntry&) const’
   40 |         Bool operator==(const ActiveRelationshipTableEntry& artEntry) const;
      |              ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.cpp:19:
/home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableEntryBase.h:58:22: error: ‘virtual Bool RelationshipTableEntryBase::operator==(const RelationshipTableEntryInterface&) const’ was hidden [-Werror=overloaded-virtual=]
   58 |         virtual Bool operator==(const RelationshipTableEntryInterface& baseEntry) const override;
      |                      ^~~~~~~~
/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.h:40:14: note:   by ‘Bool ActiveRelationshipTableEntry::operator==(const ActiveRelationshipTableEntry&) const’
   40 |         Bool operator==(const ActiveRelationshipTableEntry& artEntry) const;
      |              ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableBase.h:23,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicy.h:24,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicy.cpp:19:
/home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableEntryBase.h:58:22: error: ‘virtual Bool RelationshipTableEntryBase::operator==(const RelationshipTableEntryInterface&) const’ was hidden [-Werror=overloaded-virtual=]
   58 |         virtual Bool operator==(const RelationshipTableEntryInterface& baseEntry) const override;
      |                      ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:23:
/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.h:40:14: note:   by ‘Bool ActiveRelationshipTableEntry::operator==(const ActiveRelationshipTableEntry&) const’
   40 |         Bool operator==(const ActiveRelationshipTableEntry& artEntry) const;
      |              ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableBase.h:23,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:22,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicy.h:24,
                 from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicyInterface.cpp:19:
/home/danny/github/dptf/DPTF/Linux/Policies/../../Sources/SharedLib/DptfObjectsLib/RelationshipTableEntryBase.h:58:22: error: ‘virtual Bool RelationshipTableEntryBase::operator==(const RelationshipTableEntryInterface&) const’ was hidden [-Werror=overloaded-virtual=]
   58 |         virtual Bool operator==(const RelationshipTableEntryInterface& baseEntry) const override;
      |                      ^~~~~~~~
In file included from /home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.h:23:
/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.h:40:14: note:   by ‘Bool ActiveRelationshipTableEntry::operator==(const ActiveRelationshipTableEntry&) const’
   40 |         Bool operator==(const ActiveRelationshipTableEntry& artEntry) const;
      |              ^~~~~~~~
[ 50%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ArbitratorFanSpeed.cpp.o
cc1plus: note: unrecognized command-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make[2]: *** [Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/build.make:90: Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicyInterface.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 51%] Building CXX object Policies/PassivePolicy/CMakeFiles/DptfPolicyPassive.dir/home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/ControlStatus.cpp.o
cc1plus: note: unrecognized command-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make[2]: *** [Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/build.make:118: Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTableEntry.cpp.o] Error 1
[ 51%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ArbitratorPlatformPowerControl.cpp.o
[ 51%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ArbitratorProcessorControl.cpp.o
cc1plus: note: unrecognized command-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make[2]: *** [Policies/PassivePolicy/CMakeFiles/DptfPolicyPassive.dir/build.make:76: Policies/PassivePolicy/CMakeFiles/DptfPolicyPassive.dir/home/danny/github/dptf/DPTF/Sources/Policies/PassivePolicy/CallbackScheduler.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 51%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ArbitratorTemperatureThresholds.cpp.o
cc1plus: note: unrecognized command-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make[2]: *** [Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/build.make:104: Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActiveRelationshipTable.cpp.o] Error 1
[ 51%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ControlBase.cpp.o
[ 52%] Linking CXX shared module ../../x64/release/DptfPolicyCritical.so
[ 53%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/ControlFactoryList.cpp.o
make[1]: *** [CMakeFiles/Makefile2:969: Policies/PassivePolicy/CMakeFiles/DptfPolicyPassive.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 53%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/DomainActiveControlBase.cpp.o
[ 53%] Built target DptfPolicyCritical
[ 53%] Building CXX object UnifiedParticipant/CMakeFiles/DptfParticipant.dir/home/danny/github/dptf/DPTF/Sources/UnifiedParticipant/DomainActiveControlFactory.cpp.o
cc1plus: note: unrecognized command-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make[2]: *** [Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/build.make:76: Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/home/danny/github/dptf/DPTF/Sources/Policies/ActivePolicy/ActivePolicy.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:897: Policies/ActivePolicy/CMakeFiles/DptfPolicyActive.dir/all] Error 2

I will try removing all references to -Wno-unqualified-std-cast-call from all make files under DPTF folder and adding -Wno-error=overloaded-virtual to CMAKE_CXX_FLAGS IN DPTF/Linux/CMakeLists.txt

[GeniusTechnoMystic]

OK, that seemed to the trick, so far so good.