From 2ed5d229327ad8e71b5a2219591f8bef65525b95 Mon Sep 17 00:00:00 2001 From: Hector Sanjuan Date: Wed, 26 Mar 2025 09:29:42 +0100 Subject: [PATCH 1/2] DagModifier: allow specifying MaxLinks --- ipld/unixfs/mod/dagmodifier.go | 4 +++- ipld/unixfs/mod/dagmodifier_test.go | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ipld/unixfs/mod/dagmodifier.go b/ipld/unixfs/mod/dagmodifier.go index e3a5b7c60..f426512f7 100644 --- a/ipld/unixfs/mod/dagmodifier.go +++ b/ipld/unixfs/mod/dagmodifier.go @@ -46,6 +46,7 @@ type DagModifier struct { Prefix cid.Prefix RawLeaves bool + MaxLinks int read uio.DagReader } @@ -76,6 +77,7 @@ func NewDagModifier(ctx context.Context, from ipld.Node, serv ipld.DAGService, s ctx: ctx, Prefix: prefix, RawLeaves: rawLeaves, + MaxLinks: help.DefaultLinksPerBlock, }, nil } @@ -358,7 +360,7 @@ func (dm *DagModifier) appendData(nd ipld.Node, spl chunker.Splitter) (ipld.Node case *mdag.ProtoNode, *mdag.RawNode: dbp := &help.DagBuilderParams{ Dagserv: dm.dagserv, - Maxlinks: help.DefaultLinksPerBlock, + Maxlinks: dm.MaxLinks, CidBuilder: dm.Prefix, RawLeaves: dm.RawLeaves, } diff --git a/ipld/unixfs/mod/dagmodifier_test.go b/ipld/unixfs/mod/dagmodifier_test.go index ebbc98b10..ab69374ef 100644 --- a/ipld/unixfs/mod/dagmodifier_test.go +++ b/ipld/unixfs/mod/dagmodifier_test.go @@ -8,7 +8,6 @@ import ( dag "github.com/ipfs/boxo/ipld/merkledag" "github.com/ipfs/boxo/ipld/unixfs" - h "github.com/ipfs/boxo/ipld/unixfs/importer/helpers" trickle "github.com/ipfs/boxo/ipld/unixfs/importer/trickle" uio "github.com/ipfs/boxo/ipld/unixfs/io" testu "github.com/ipfs/boxo/ipld/unixfs/test" @@ -46,7 +45,7 @@ func verifyNode(t *testing.T, orig []byte, dm *DagModifier, opts testu.NodeOpts) err = trickle.VerifyTrickleDagStructure(nd, trickle.VerifyParams{ Getter: dm.dagserv, - Direct: h.DefaultLinksPerBlock, + Direct: dm.MaxLinks, LayerRepeat: 4, Prefix: &opts.Prefix, RawLeaves: opts.RawLeavesUsed, From 6a9ebc4dfb2c13f2e082121055aaf9bcba671e88 Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Mon, 7 Apr 2025 23:56:03 +0200 Subject: [PATCH 2/2] docs: changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf12f462c..35b4d800d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ The following emojis are used to highlight certain changes: ### Added +- `ipld/unixfs`: DagModifier now allows specifying max DAG Width (`MaxLinks`) [#898](https://github.com/ipfs/boxo/pull/898) + ### Changed - upgrade to `go-libp2p` [v0.41.1](https://github.com/libp2p/go-libp2p/releases/tag/v0.41.1)