From e7e296d8a995765e5ba90fae97255096e4412367 Mon Sep 17 00:00:00 2001 From: iqbalpa Date: Fri, 11 Jul 2025 07:47:29 +0700 Subject: [PATCH 1/2] feat: adjust error status code in handler --- internal/handler/task.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/handler/task.go b/internal/handler/task.go index 0d64aca..9d47188 100644 --- a/internal/handler/task.go +++ b/internal/handler/task.go @@ -49,7 +49,7 @@ func (th *TaskHandler) CreateTask(c *fiber.Ctx) error { t, err := th.s.CreateTask(ctr.Title, ctr.Description) if err != nil { utils.ErrorLogger.Println("Failed to create a new task:\n", err) - return c.JSON(err) + return c.Status(fiber.StatusInternalServerError).JSON(err) } return c.JSON(t) } @@ -66,7 +66,7 @@ func (th *TaskHandler) GetAllTasks(c *fiber.Ctx) error { tasks, err := th.s.GetAllTasks() if err != nil { utils.ErrorLogger.Println("Failed to get all tasks:\n", err) - return c.JSON(err) + return c.Status(fiber.StatusInternalServerError).JSON(err) } return c.JSON(tasks) } @@ -85,7 +85,7 @@ func (th *TaskHandler) GetTaskByID(c *fiber.Ctx) error { t, err := th.s.GetTaskByID(id) if err != nil { utils.ErrorLogger.Printf("Failed to get task with id %s:\n%s", id, err) - return c.JSON(err) + return c.Status(fiber.StatusNotFound).JSON(err) } return c.JSON(t) } @@ -117,7 +117,7 @@ func (th *TaskHandler) UpdateTask(c *fiber.Ctx) error { ) if err != nil { utils.ErrorLogger.Printf("Failed to update task with id %s:\n%s", id, err) - return c.JSON(err) + return c.Status(fiber.StatusInternalServerError).JSON(err) } return c.JSON(t) } @@ -136,7 +136,7 @@ func (th *TaskHandler) DeleteTask(c *fiber.Ctx) error { t, err := th.s.DeleteTask(id) if err != nil { utils.ErrorLogger.Printf("Failed to delete task with id %s:\n%s", id, err) - return c.JSON(err) + return c.Status(fiber.StatusInternalServerError).JSON(err) } return c.JSON(t) } From dbd8f05aa8d92ef20f23d42b3f0285209faf25d6 Mon Sep 17 00:00:00 2001 From: iqbalpa Date: Fri, 11 Jul 2025 07:48:13 +0700 Subject: [PATCH 2/2] docs: update swagger --- docs/docs.go | 12 ++++-------- docs/swagger.json | 12 ++++-------- docs/swagger.yaml | 11 ++++------- internal/handler/task.go | 5 ++--- 4 files changed, 14 insertions(+), 26 deletions(-) diff --git a/docs/docs.go b/docs/docs.go index b4f73ee..2d7ce33 100644 --- a/docs/docs.go +++ b/docs/docs.go @@ -135,8 +135,8 @@ const docTemplate = `{ "$ref": "#/definitions/model.Task" } }, - "404": { - "description": "Not Found", + "500": { + "description": "Internal Server Error", "schema": {} } } @@ -178,12 +178,8 @@ const docTemplate = `{ "$ref": "#/definitions/model.Task" } }, - "400": { - "description": "Bad Request", - "schema": {} - }, - "404": { - "description": "Not Found", + "500": { + "description": "Internal Server Error", "schema": {} } } diff --git a/docs/swagger.json b/docs/swagger.json index f447efe..d618e7b 100644 --- a/docs/swagger.json +++ b/docs/swagger.json @@ -124,8 +124,8 @@ "$ref": "#/definitions/model.Task" } }, - "404": { - "description": "Not Found", + "500": { + "description": "Internal Server Error", "schema": {} } } @@ -167,12 +167,8 @@ "$ref": "#/definitions/model.Task" } }, - "400": { - "description": "Bad Request", - "schema": {} - }, - "404": { - "description": "Not Found", + "500": { + "description": "Internal Server Error", "schema": {} } } diff --git a/docs/swagger.yaml b/docs/swagger.yaml index e32a124..057cbc2 100644 --- a/docs/swagger.yaml +++ b/docs/swagger.yaml @@ -103,8 +103,8 @@ paths: description: OK schema: $ref: '#/definitions/model.Task' - "404": - description: Not Found + "500": + description: Internal Server Error schema: {} summary: Delete a task tags: @@ -153,11 +153,8 @@ paths: description: OK schema: $ref: '#/definitions/model.Task' - "400": - description: Bad Request - schema: {} - "404": - description: Not Found + "500": + description: Internal Server Error schema: {} summary: Update a task tags: diff --git a/internal/handler/task.go b/internal/handler/task.go index 9d47188..74d1479 100644 --- a/internal/handler/task.go +++ b/internal/handler/task.go @@ -99,8 +99,7 @@ func (th *TaskHandler) GetTaskByID(c *fiber.Ctx) error { // @Param id path string true "Task ID" // @Param request body model.UpdateTaskRequest true "Update Task Body" // @Success 200 {object} model.Task -// @Failure 400 {object} error -// @Failure 404 {object} error +// @Failure 500 {object} error // @Router /api/task/{id} [patch] func (th *TaskHandler) UpdateTask(c *fiber.Ctx) error { id := c.Params("id") @@ -129,7 +128,7 @@ func (th *TaskHandler) UpdateTask(c *fiber.Ctx) error { // @Produce json // @Param id path string true "Task ID" // @Success 200 {object} model.Task -// @Failure 404 {object} error +// @Failure 500 {object} error // @Router /api/task/{id} [delete] func (th *TaskHandler) DeleteTask(c *fiber.Ctx) error { id := c.Params("id")