Support for soap 1.2 in com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection

[glassfishrobot]

Change
// let HTTP_INTERNAL_ERROR (500) through because it is used for SOAP faults
if (responseCode == HttpURLConnection.HTTP_INTERNAL_ERROR)

{ isFailure = true; }

to

// let HTTP_INTERNAL_ERROR (500) and HTTP_BAD_REQUEST (400) through because it is used for SOAP faults
if (responseCode == HttpURLConnection.HTTP_INTERNAL_ERROR || responseCode == HttpURLConnection.HTTP_BAD_REQUEST) { isFailure = true; }

This in light of table 20 of the SOAP 1.2 spec, http://www.w3.org/TR/soap12-part2/#http-respbindprocess, including the following entry

env:Sender 400 "Bad Request"

Environment

Java 1.6, 1.7 and 1.8

Affected Versions

[1.3.16]

[glassfishrobot]

Reported by theokramer

[glassfishrobot]

Was assigned to gagordon

[glassfishrobot]

mmusaji said:
To the owners - this should be marked as a bug not an improvement.

[glassfishrobot]

mmusaji said:
I'm trying to provide a PR for this fix. I'm trying to push to ssh://mmusaji@git.java.net/saaj~git but I'm getting permission errors after providing my public key.

remote: user mmusaji is not authorized to write to repository saaj~git
To ssh://mmusaji@git.java.net/saaj~git
 ! [remote rejected] SAAJ-74 -> SAAJ-74 (pre-receive hook declined)
error: failed to push some refs to 'ssh://mmusaji@git.java.net/saaj~git'

Anyone provide me with instructions on how to provide a PR against this project please?

[glassfishrobot]

slandro said:
It seems Oracle is not investing much time supporting SAAJ. I subscribed to users@saaj.java.net to make Oracle aware of a bug I filed earlier and it has been at least partially fixed.

[glassfishrobot]

wolfc said:
Since I can not attach the patch here, I've attached it to https://issues.jboss.org/browse/WFLY-3966

[glassfishrobot]

This issue was imported from java.net JIRA SAAJ-74