From 22a648b0807b88d76bf1bc4723c6b8e4b94fa504 Mon Sep 17 00:00:00 2001 From: Ryoichi Taniguchi Date: Tue, 16 Feb 2016 11:32:29 +0900 Subject: [PATCH] fixed NPE in FileModelProxy.java NPE while handling resources for the summary table Change-Id: I8d91b6d2326b0dacc621d424123e4a270c8be697 --- .../violations/render/FileModelProxy.java | 43 ++++++++++--------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/src/main/java/hudson/plugins/violations/render/FileModelProxy.java b/src/main/java/hudson/plugins/violations/render/FileModelProxy.java index ff8a9af..d05366f 100644 --- a/src/main/java/hudson/plugins/violations/render/FileModelProxy.java +++ b/src/main/java/hudson/plugins/violations/render/FileModelProxy.java @@ -432,27 +432,28 @@ public String getSummaryTable() { gst.append(" Description\n"); gst.append(" \n"); - Set violations = fileModel.get().getLineViolationMap().get(0); - - for (Violation v : violations) { - ++count; - gst.append(" \n"); - gst.append(" "); - gst.append(count); - gst.append("\n"); - gst.append(" "); - gst.append(v.getType()); - gst.append("\n"); - gst.append(" "); - gst.append(v.getSource()); - gst.append("\n"); - gst.append(" "); - gst.append(v.getMessage()); - gst.append("\n"); - gst.append(" "); - gst.append(v.getPopupMessage()); - gst.append("\n"); - gst.append(" \n"); + for (Entry> violations : fileModel.get() + .getLineViolationMap().entrySet()) { + for (Violation v : violations.getValue()) { + ++count; + gst.append(" \n"); + gst.append(" "); + gst.append(count); + gst.append("\n"); + gst.append(" "); + gst.append(v.getType()); + gst.append("\n"); + gst.append(" "); + gst.append(v.getSource()); + gst.append("\n"); + gst.append(" "); + gst.append(v.getMessage()); + gst.append("\n"); + gst.append(" "); + gst.append(v.getPopupMessage()); + gst.append("\n"); + gst.append(" \n"); + } } gst.append(" \n"); gst.append("


\n");