Skip to content

Minor CSS tweak to automatically update the shell's color when on Dar… #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georapbox wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor CSS tweak to automatically update the shell's color when on Dar… #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Brackets-Shell adds a new icon on the right panel: click on it to toggle the she
##Options
Brackets-Shell adds the following options to your brackets.json file:

* `hdy.brackets-shell.dark`: set to true if you are using Bracket's dark theme (defaults to false)
* `hdy.brackets-shell.trackProject`: set to true if you want to have the Bracket's shell automatically be set to your project's root directory
* `hdy.brackets-shell.shell`: set to the path of your shell (i.e "/bin/sh" or "/bin/bash"). For Windows this should be set to "cmd.exe"

Expand Down
Binary file removed images/hdy.brackets.shell.toolbar.on.png
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions images/hdy.brackets.shell.toolbar.on.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed images/hdy.brackets.shell.toolbar.png
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions images/hdy.brackets.shell.toolbar.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 0 additions & 8 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ define(function (require, exports, module) {
.attr("title", "Shell")
.appendTo($("#main-toolbar .buttons"));


// Default theme if not defined
if(Preferences.get("dark") === undefined) {
Preferences.definePreference("dark", "boolean", false);
Preferences.set("dark", false);
Preferences.save();
}

// Default projectTracking if not defined
if(Preferences.get("trackProject") === undefined) {
Preferences.definePreference("trackProject", "boolean", true);
Expand Down
4 changes: 0 additions & 4 deletions shellPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,6 @@ define(function (require, exports, module) {
currentCommandResult.append($("<pre>"));
}

if (_preferences.get("dark")) {
$("pre", currentCommandResult).addClass('hdy-dark-theme');
}

if(ansiFormat.hasAceptedAnsiFormat(data)){
ansiFormat.formattedText(data, currentCommandResult);
} else {
Expand Down
12 changes: 6 additions & 6 deletions styles/shellPanel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
background: transparent;
}

.dark .hdy-command-result pre {
color: #AAAAAA;
}

.hdy-error {
color: #ff0000;
color: rgba(255, 0, 0, 0.6);
Expand Down Expand Up @@ -45,15 +49,11 @@ div:focus {
}

.hdy-shell-icon-off {
background: url(../images/hdy.brackets.shell.toolbar.png);
background: url(../images/hdy.brackets.shell.toolbar.svg) no-repeat center;
}

.hdy-shell-icon-on {
background: url(../images/hdy.brackets.shell.toolbar.on.png);
}

.hdy-dark-theme {
color:#AAAAAA;
background: url(../images/hdy.brackets.shell.toolbar.on.svg) no-repeat center;
}

.hdy-red {
Expand Down