From f4138fa780e24ae5e700900263d8f177adbeafc7 Mon Sep 17 00:00:00 2001 From: James Talbot Date: Wed, 1 Apr 2020 17:16:47 +0100 Subject: [PATCH 1/3] Tweaks to PageviewEngagement tracking * Remove `completion` requests * Add `view_type=a` to engagement requests --- extensions/amp-analytics/0.1/test/vendor-requests.json | 3 +-- extensions/amp-analytics/0.1/vendors/permutive.json | 10 +--------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/extensions/amp-analytics/0.1/test/vendor-requests.json b/extensions/amp-analytics/0.1/test/vendor-requests.json index fc15bbd3477b..94b4f2b7b955 100644 --- a/extensions/amp-analytics/0.1/test/vendor-requests.json +++ b/extensions/amp-analytics/0.1/test/vendor-requests.json @@ -334,8 +334,7 @@ "permutive": { "track": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "pageview": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", - "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_engaged_time=_incremental_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", - "completion": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_engaged_time=_incremental_engaged_time_&_ep_completion=0.25&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", + "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=_incremental_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "custom": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=!event&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_" }, "piStats": { diff --git a/extensions/amp-analytics/0.1/vendors/permutive.json b/extensions/amp-analytics/0.1/vendors/permutive.json index 631d3f15bba0..4e552f95dd05 100644 --- a/extensions/amp-analytics/0.1/vendors/permutive.json +++ b/extensions/amp-analytics/0.1/vendors/permutive.json @@ -6,8 +6,7 @@ "requests": { "track": "https://${namespace}.amp.permutive.com/track?k=${key}&i=${identity}&it=amp&vid=${viewId}&s=${viewId}", "pageview": "${track}&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info", - "engagement": "${track}&e=PageviewEngagement&_ep_engaged_time=${incrementalEngagedTime}", - "completion": "${engagement}&_ep_completion=0.25", + "engagement": "${track}&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=${incrementalEngagedTime}", "custom": "${track}&e=${event}" }, "triggers": { @@ -21,13 +20,6 @@ "visibilitySpec": { "reportWhen": "documentExit" } - }, - "trackCompletion": { - "on": "scroll", - "scrollSpec": { - "verticalBoundaries": [25, 50, 75, 100] - }, - "request": "completion" } }, "transport": { From a2c329e25fc777602bbf19844db3533fae6fb116 Mon Sep 17 00:00:00 2001 From: James Talbot Date: Wed, 1 Apr 2020 18:21:49 +0100 Subject: [PATCH 2/3] use total instead of incremental engaged time --- extensions/amp-analytics/0.1/test/vendor-requests.json | 2 +- extensions/amp-analytics/0.1/vendors/permutive.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/amp-analytics/0.1/test/vendor-requests.json b/extensions/amp-analytics/0.1/test/vendor-requests.json index 94b4f2b7b955..a1a20ee1e581 100644 --- a/extensions/amp-analytics/0.1/test/vendor-requests.json +++ b/extensions/amp-analytics/0.1/test/vendor-requests.json @@ -334,7 +334,7 @@ "permutive": { "track": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "pageview": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", - "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=_incremental_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", + "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=_total_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "custom": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=!event&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_" }, "piStats": { diff --git a/extensions/amp-analytics/0.1/vendors/permutive.json b/extensions/amp-analytics/0.1/vendors/permutive.json index 4e552f95dd05..3b6f5fba4df0 100644 --- a/extensions/amp-analytics/0.1/vendors/permutive.json +++ b/extensions/amp-analytics/0.1/vendors/permutive.json @@ -6,7 +6,7 @@ "requests": { "track": "https://${namespace}.amp.permutive.com/track?k=${key}&i=${identity}&it=amp&vid=${viewId}&s=${viewId}", "pageview": "${track}&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info", - "engagement": "${track}&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=${incrementalEngagedTime}", + "engagement": "${track}&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=${totalEngagedTime}", "custom": "${track}&e=${event}" }, "triggers": { From 6a3bdb701a7091a0bdd97af6289b93ae2f6f10e1 Mon Sep 17 00:00:00 2001 From: James Talbot Date: Fri, 3 Apr 2020 11:29:36 +0100 Subject: [PATCH 3/3] rename engagement event to PageviewEngagementAggregate --- extensions/amp-analytics/0.1/test/vendor-requests.json | 2 +- extensions/amp-analytics/0.1/vendors/permutive.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/amp-analytics/0.1/test/vendor-requests.json b/extensions/amp-analytics/0.1/test/vendor-requests.json index a1a20ee1e581..6a7969a199fe 100644 --- a/extensions/amp-analytics/0.1/test/vendor-requests.json +++ b/extensions/amp-analytics/0.1/test/vendor-requests.json @@ -334,7 +334,7 @@ "permutive": { "track": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "pageview": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", - "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=_total_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", + "engagement": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=PageviewEngagementAggregate&_ep_total_engaged_time=_total_engaged_time_&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_", "custom": "https://!namespace.amp.permutive.com/track?k=!key&i=_client_id(_ga)_&it=amp&vid=_page_view_id_64_&s=_page_view_id_64_&e=!event&_ep_client.type=amp&_ep_client.title=_title_&_ep_client.domain=_canonical_host_&_ep_client.url=_canonical_url_&_ep_client.referrer=_document_referrer_&_ep_client.user_agent=_user_agent_" }, "piStats": { diff --git a/extensions/amp-analytics/0.1/vendors/permutive.json b/extensions/amp-analytics/0.1/vendors/permutive.json index 3b6f5fba4df0..0fb7590cd256 100644 --- a/extensions/amp-analytics/0.1/vendors/permutive.json +++ b/extensions/amp-analytics/0.1/vendors/permutive.json @@ -6,7 +6,7 @@ "requests": { "track": "https://${namespace}.amp.permutive.com/track?k=${key}&i=${identity}&it=amp&vid=${viewId}&s=${viewId}", "pageview": "${track}&e=Pageview&_ep_isp_info=%24ip_isp_info&_ep_geo_info=%24ip_geo_info", - "engagement": "${track}&e=PageviewEngagement&_ep_view_type=a&_ep_engaged_time=${totalEngagedTime}", + "engagement": "${track}&e=PageviewEngagementAggregate&_ep_total_engaged_time=${totalEngagedTime}", "custom": "${track}&e=${event}" }, "triggers": {