From 90da89e743af3a07429c03e2bb46ed54456896e8 Mon Sep 17 00:00:00 2001 From: sujon Date: Wed, 5 Mar 2025 15:50:08 +0600 Subject: [PATCH] In route file title parameter added as optional, and inside controller parameter order is changed. Else route will throw error. --- src/JasperReportPublisherController.php | 2 +- src/Route/route.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/JasperReportPublisherController.php b/src/JasperReportPublisherController.php index 0b0643f..9b3bf34 100644 --- a/src/JasperReportPublisherController.php +++ b/src/JasperReportPublisherController.php @@ -29,7 +29,7 @@ public function __construct(JasperReport $jasperReport) * @param Request $request * @return mixed */ - public function render($title = "report",Request $request) { + public function render(Request $request, $title = "report") { /** configuring with jasper credentials */ $this->jasperReport->setServerUrl(config('jasper.server_url')) ->setUsername(config('jasper.username')) diff --git a/src/Route/route.php b/src/Route/route.php index b9b06f9..4170cfc 100644 --- a/src/Route/route.php +++ b/src/Route/route.php @@ -1,6 +1,6 @@ ['web']], function () { - Route::any('/jasper/report/render', 'Julfiker\Jasper\JasperReportPublisherController@render')->name('julfiker.jasper.report.render'); + Route::any('/jasper/report/render/{title?}', 'Julfiker\Jasper\JasperReportPublisherController@render')->name('julfiker.jasper.report.render'); });