Merged
Conversation
odow
reviewed
Dec 14, 2025
odow
reviewed
Dec 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 96.34% 96.36% +0.02%
==========================================
Files 12 12
Lines 656 660 +4
==========================================
+ Hits 632 636 +4
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blegat
commented
Dec 15, 2025
| src::MOI.Utilities.UniversalFallback{OptimizerCache{T}}, | ||
| ) where {T} | ||
| linear_solver = get(dest.options, :linear_solver, DirectSolver) | ||
| # TODO otherwise, just convert the inner indices, no big deal |
Member
Author
There was a problem hiding this comment.
@odow I think we still need to resolve this before we release. Otherwise, in case someone changes the DirectSolver after MOI.instantiate is called, there with be an AssertionError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, this isn't used by JuMP so we lose most of the performance advantage of using
MatrixOfConstraints