diff --git a/.flake8 b/.flake8 deleted file mode 100644 index 7dfa6ed49..000000000 --- a/.flake8 +++ /dev/null @@ -1,8 +0,0 @@ -[flake8] -# OpenAeroStruct-specific settings in addition to the MDO Lab standard config file. -extend-exclude = - openaerostruct/docs/conf.py, - openaerostruct/docs/aero_walkthrough/part*.py, - openaerostruct/docs/_utils/docutil.py, - openaerostruct/docs/_utils/patch.py, - openaerostruct/utils/plot_*.py, diff --git a/.gitignore b/.gitignore index bf8c8aedf..8a939a13d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,9 @@ # Ignore OpenMDAO reports folders **/reports/ +# pre-commit config file that should be manually copied from the mdolab/.github repo. +.pre-commit-config.yaml + *.pyc *.py~ *.db diff --git a/.readthedocs.yaml b/.readthedocs.yaml index 4d7f9738a..1257c6976 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -11,8 +11,7 @@ build: tools: python: "3.11" -sphinx: - configuration: openaerostruct/docs/conf.py + python: install: diff --git a/CITATION.cff b/CITATION.cff index f696d8c71..aec49a916 100644 --- a/CITATION.cff +++ b/CITATION.cff @@ -28,4 +28,4 @@ preferred-citation: number: "4" pages: "1815--1827" date: "2018-04" - doi: "10.1007/s00158-018-1912-8" \ No newline at end of file + doi: "10.1007/s00158-018-1912-8" diff --git a/openaerostruct/aerodynamics/aero_groups.py b/openaerostruct/aerodynamics/aero_groups.py index 0b5981d24..8e0ee2a1b 100644 --- a/openaerostruct/aerodynamics/aero_groups.py +++ b/openaerostruct/aerodynamics/aero_groups.py @@ -23,7 +23,7 @@ def initialize(self): "compressible", types=bool, default=False, - desc="Turns on compressibility correction for moderate Mach number " "flows. Defaults to False.", + desc="Turns on compressibility correction for moderate Mach number flows. Defaults to False.", ) def setup(self): diff --git a/openaerostruct/aerodynamics/compressible_states.py b/openaerostruct/aerodynamics/compressible_states.py index 5e9cf29e6..308cc052c 100644 --- a/openaerostruct/aerodynamics/compressible_states.py +++ b/openaerostruct/aerodynamics/compressible_states.py @@ -1,6 +1,7 @@ """ Class definition for CompressibleVLMStates. """ + import openmdao.api as om from openaerostruct.aerodynamics.get_vectors import GetVectors diff --git a/openaerostruct/aerodynamics/functionals.py b/openaerostruct/aerodynamics/functionals.py index 98ff29048..c4ac32a02 100644 --- a/openaerostruct/aerodynamics/functionals.py +++ b/openaerostruct/aerodynamics/functionals.py @@ -57,5 +57,5 @@ def setup(self): ) self.add_subsystem( - "CD", TotalDrag(surface=surface), promotes_inputs=["CDv", "CDi", "CDw"], promotes_outputs=["CD"] + "CD", TotalDrag(surface=surface), promotes_inputs=["CDv", "CDi", "CDw", "CD0"], promotes_outputs=["CD"] ) diff --git a/openaerostruct/aerodynamics/geometry.py b/openaerostruct/aerodynamics/geometry.py index 91ceeae1c..e93a18a22 100644 --- a/openaerostruct/aerodynamics/geometry.py +++ b/openaerostruct/aerodynamics/geometry.py @@ -11,7 +11,7 @@ class VLMGeometry(om.ExplicitComponent): Some of the quantities, like `normals`, are used to compute the RHS of the AIC linear system. - parameters + Parameters ---------- def_mesh[nx, ny, 3] : numpy array Array defining the nodal coordinates of the lifting surface. diff --git a/openaerostruct/aerodynamics/lift_drag.py b/openaerostruct/aerodynamics/lift_drag.py index a96615828..91fbae99c 100644 --- a/openaerostruct/aerodynamics/lift_drag.py +++ b/openaerostruct/aerodynamics/lift_drag.py @@ -8,7 +8,7 @@ class LiftDrag(om.ExplicitComponent): Calculate total lift and drag in force units based on section forces. This is for one given lifting surface. - parameters + Parameters ---------- sec_forces[nx-1, ny-1, 3] : numpy array Contains the sectional forces acting on each panel. diff --git a/openaerostruct/aerodynamics/mesh_point_forces.py b/openaerostruct/aerodynamics/mesh_point_forces.py index 4699d58c7..0188b25e4 100644 --- a/openaerostruct/aerodynamics/mesh_point_forces.py +++ b/openaerostruct/aerodynamics/mesh_point_forces.py @@ -1,6 +1,7 @@ """ Class definition for the MeshPointForces component. """ + import numpy as np import openmdao.api as om diff --git a/openaerostruct/aerodynamics/total_drag.py b/openaerostruct/aerodynamics/total_drag.py index 38fef9103..c509e33f0 100644 --- a/openaerostruct/aerodynamics/total_drag.py +++ b/openaerostruct/aerodynamics/total_drag.py @@ -4,7 +4,7 @@ class TotalDrag(om.ExplicitComponent): """Calculate total drag in force units. - parameters + Parameters ---------- CDi : float Induced coefficient of drag (CD) for the lifting surface. @@ -26,14 +26,14 @@ def setup(self): self.add_input("CDi", val=1.0) self.add_input("CDv", val=1.0) self.add_input("CDw", val=1.0) + self.add_input("CD0", val=surface["CD0"]) self.add_output("CD", val=1.0, tags=["mphys_result"]) - self.CD0 = surface["CD0"] - self.declare_partials("CD", "CDi", val=1.0) self.declare_partials("CD", "CDv", val=1.0) self.declare_partials("CD", "CDw", val=1.0) + self.declare_partials("CD", "CD0", val=1.0) def compute(self, inputs, outputs): - outputs["CD"] = inputs["CDi"] + inputs["CDv"] + inputs["CDw"] + self.CD0 + outputs["CD"] = inputs["CDi"] + inputs["CDv"] + inputs["CDw"] + inputs["CD0"] diff --git a/openaerostruct/aerodynamics/wave_drag.py b/openaerostruct/aerodynamics/wave_drag.py index 0b58e6b22..2b013d1f3 100644 --- a/openaerostruct/aerodynamics/wave_drag.py +++ b/openaerostruct/aerodynamics/wave_drag.py @@ -126,9 +126,7 @@ def compute_partials(self, inputs, partials): ccos = np.sum(widths * panel_mid_chords) ccos2w = np.sum(panel_mid_chords * widths**2 / lengths_spanwise) - davgdcos = ( - 2 * panel_mid_chords * widths / lengths_spanwise / ccos - panel_mid_chords * ccos2w / ccos**2 - ) + davgdcos = 2 * panel_mid_chords * widths / lengths_spanwise / ccos - panel_mid_chords * ccos2w / ccos**2 dtocdcos = ( panel_mid_chords * t_over_c / ccos - panel_mid_chords * np.sum(panel_mid_chords * widths * t_over_c) / ccos**2 diff --git a/openaerostruct/docs/_n2html/generate_n2_n2.html b/openaerostruct/docs/_n2html/generate_n2_n2.html index 11ce9d1b5..129601531 100644 --- a/openaerostruct/docs/_n2html/generate_n2_n2.html +++ b/openaerostruct/docs/_n2html/generate_n2_n2.html @@ -356,7 +356,7 @@ /* transition: opacity 0.25s; */ box-shadow: 3px 3px 3px 1px rgba(0, 0, 0, 0.2); border-radius: 10px; - + overflow: hidden; } @@ -487,7 +487,7 @@ .window-theme-value-info .window-body table tbody tr td { text-align: left; font-size: 9pt; - margin: 0; + margin: 0; border-top: 0; border-left: 0; border-bottom: 1px solid #a0a0a0; @@ -507,7 +507,7 @@ .show_value_button { background-color: #c1c1c1; } - + .copy_value_button { background-color: #c1c1c1; } @@ -2858,7 +2858,7 @@

Toolbar Help