SidekickJS detected issues in push

[karolk]

SidekickJS detected the following issues in this commit:

source/value.js 30 issues:

• Unused variable: 'Value'
• 'conf' is already defined.
• 'instance_of_Value' was used before it was defined.
• 'handle_format_change' was used before it was defined.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected a 'break' statement before 'default'.
• 'is_numeric' was used before it was defined.
• 'numeric_positive' was used before it was defined.
• 'numeric_negative' was used before it was defined.
• Unnecessary semicolon.
• 'input' is already defined.
• Repetition of 14 lines
• Repetition of 14 lines
• Repetition of 10 lines
• 'callback' is already defined.
• Repetition of 10 lines
• 'callback' is already defined.
• 'test_value' is already defined.
• 'test_value' used out of scope.
• 'test_value' used out of scope.
• 'test_value' used out of scope.
• 'test_value' used out of scope.
• 'test_value' used out of scope.
• Empty block.
• Empty block.
• Repetition of 23 lines
• Repetition of 23 lines
• Repetition of 1 lines
• Unused variable: 'new_min'
• Unused variable: 'new_max'
• Unnecessary semicolon.

tests.js 118 issues:

• Implied global 'console'
• 'console' is not defined.
• 'console' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• Implied global 'Value'
• Implied global 'a'
• 'b' is not defined.
• 'b' is not defined.
• Implied global 'b'
• 'Value' is not defined.
• Missing 'new' prefix when invoking a constructor.
• Missing 'new' prefix when invoking a constructor.
• 'c' is not defined.
• 'Value' is not defined.
• 'c' is not defined.
• Implied global 'c'
• Implied global 'd'
• 'd' is not defined.
• 'Value' is not defined.
• 'd' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• 'b' is not defined.
• 'Value' is not defined.
• 'c' is not defined.
• 'Value' is not defined.
• 'd' is not defined.
• 'Value' is not defined.
• 'Value' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• 'a' is not defined.
• Repetition of 1 lines
• 'a' is not defined.
• Repetition of 1 lines
• 'Value' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• Repetition of 1 lines
• 'a' is not defined.
• 'a' is not defined.
• 'c' is not defined.
• 'c' is not defined.
• 'c' is not defined.
• 'd' is not defined.
• 'd' is not defined.
• 'd' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'Value' is not defined.
• 'Value' is not defined.
• 'd' is not defined.
• 'd' is not defined.
• 'Value' is not defined.
• 'Value' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'a' is not defined.
• 'd' is not defined.
• 'd' is not defined.
• Repetition of 1 lines
• 'b' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• Repetition of 1 lines
• 'b' is not defined.
• 'Value' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• Repetition of 1 lines
• 'b' is not defined.
• 'Value' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• 'Value' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• Repetition of 1 lines
• 'Value' is not defined.
• 'b' is not defined.
• 'Value' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• Repetition of 1 lines
• 'b' is not defined.
• Implied global 'x'
• 'x' is not defined.
• 'b' is not defined.
• 'b' is not defined.
• 'x' is not defined.
• 'b' is not defined.
• Implied global 'y'
• 'y' is not defined.
• 'b' is not defined.
• 'y' is not defined.
• 'b' is not defined.
• 'x' is not defined.
• 'b' is not defined.
• 'y' is not defined.
• 'b' is not defined.
• 'x' is not defined.
• 'b' is not defined.
• 'x' is not defined.
• 'x' is not defined.
• 'b' is not defined.
• 'y' is not defined.
• 'b' is not defined.
• 'x' is not defined.
• 'y' is not defined.
• 'x' is not defined.
• 'y' is not defined.
• 'b' is not defined.

value.js 57 issues:

• Expected ')' to match '(' from line 1 and instead saw ','.
• Expected an operator and instead saw 'typeof'.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an identifier and instead saw ')'.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• Expected an assignment or function call and instead saw an expression.
• This 'switch' should be an 'if'.
• Unused variable: 'Value'
• 'c' is already defined.
• Expected ':' and instead saw 'b'.
• Expected an identifier and instead saw ')'.
• Expected '}' to match '{' from line 2 and instead saw ':'.
• Unused variable: 'z'
• Unused variable: 't'
• Unused variable: 's'
• Unused variable: 'p'
• Unused variable: 'o'
• Unused variable: 'h'
• Unused variable: 'g'
• Expected ')' to match '(' from line 2 and instead saw ','.
• Expected ':' and instead saw 'o'.
• Expected an assignment or function call and instead saw an expression.
• Unnecessary semicolon.
• Expected ')' to match '(' from line 3 and instead saw ','.
• Label 'format_thousands' on r statement.
• Expected an identifier and instead saw '='.
• Expected an assignment or function call and instead saw an expression.
• Expected an identifier and instead saw ')'.
• Expected an assignment or function call and instead saw an expression.
• Expected '}' to match '{' from line 3 and instead saw ':'.
• Expected an assignment or function call and instead saw an expression.
• Expected '(end)' and instead saw '}'.
• 'b' is not defined.
• 'e' is not defined.
• 'i' is not defined.
• 'i' is not defined.
• 'p' is not defined.
• 'i' is not defined.
• 'b' is not defined.
• 'i' is not defined.
• Implied global 'b'
• Repetition of 1 lines
• Implied global 'i'
• Implied global 'p'
• Expected an assignment or function call and instead saw an expression.
• Label 'nill' on j statement.
• Expected an assignment or function call and instead saw an expression.
• Label 'position' on q statement.
• Expected an assignment or function call and instead saw an expression.
• Label 'symbol' on n statement.
• Expected an assignment or function call and instead saw an expression.
• Label 'separator' on m statement.
• Repetition of 1 lines
• Implied global 'e'
• Repetition of 2 lines
• Repetition of 1 lines
• Repetition of 1 lines