chore(common): building on Linux requires files from `common/windows`

[ermshiperete]

When using ${KEYMAN_ROOT}/build.sh to build on Linux, the build will fail if it can't find files from /common/windows:

…
icu-for-uset| Configuring uconfig_local.h using configuration
icu-for-uset| Build targets in project: 2
icu-for-uset| Subproject icu-for-uset finished.


src/meson.build:68:6: ERROR: File ../../../../common/windows/cpp/src/ConvertUTF.c does not exist.

A full log can be found at /tmp/keyman/developer/src/kmcmplib/build/wasm/debug/meson-logs/meson-log.txt
[developer/src/kmcmplib] ## configure:wasm failed
…

[mcdurdin]

Good catch. This comes from windows and developer having shared sources in the past, and some of these tools running only on Windows - kmcmpdll (now kmcmplib), kmanalyze, kmdecomp.

Looks like we need to move files to common/cpp, and corresponding header files to common/include, and fixup any references:

From meson.build:

  '../../../../common/windows/cpp/src/ConvertUTF.c',
  '../../../../common/windows/cpp/src/crc32.cpp',
  '../../../../common/windows/cpp/src/vkeys.cpp',

While we are at it, we should analyze source for windows/cpp and windows/include references and consider addressing any remaining references outside the windows/ sources:

35 results - 20 files

developer\src\kmanalyze\kmanalyze.cpp:
    5: #include "../../../common/windows/cpp/include/keymanversion.h"
  367: #include "../../../common/windows/cpp/include/vkeys.h"

developer\src\kmanalyze\pch.h:
  18: #include "../../../common/windows/cpp/include/keymansentry.h"
  19: #include "../../../common/windows/cpp/include/legacy_kmx_file.h"
  20: #include "../../../common/windows/cpp/include/legacy_kmx_memory.h"
  21: #include "../../../common/windows/cpp/include/unicode.h"
  22: #include "../../../common/windows/cpp/include/xstring.h"

developer\src\kmanalyze\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmcmplib\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmcmplib\src\CasedKeys.cpp:
  5: #include "../../../../common/windows/cpp/include/vkeys.h"

developer\src\kmcmplib\src\CompileKeyboardBuffer.cpp:
  8: #include "../../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmcmplib\src\Compiler.cpp:
  73: #include "../../../../common/windows/cpp/include/vkeys.h"
  82: #include "../../../../common/windows/cpp/include/keymanversion.h"
  83: #include "../../../../common/windows/cpp/include/crc32.h"
  84: #include "../../../../common/windows/cpp/include/ConvertUTF.h"

developer\src\kmcmplib\src\CompilerInterfaces.cpp:
  5: #include "../../../../common/windows/cpp/include/ConvertUTF.h"

developer\src\kmcmplib\src\meson.build:
  90:   '../../../../common/windows/cpp/src/ConvertUTF.c',
  91:   '../../../../common/windows/cpp/src/crc32.cpp',
  92:   '../../../../common/windows/cpp/src/vkeys.cpp',

developer\src\kmcmplib\src\pch.h:
  10: #include "../../../../common/windows/cpp/include/crc32.h"

developer\src\kmcmplib\src\UnreachableRules.cpp:
  6: #include "../../../../common/windows/cpp/include/vkeys.h"

developer\src\kmcmplib\src\version.rc:
  1: #include "../../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmconvert\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmdbrowserhost\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\kmdecomp\kmdecomp.cpp:
  23: #include "../../../common/windows/cpp/include/keymansentry.h"
  24: #include "../../../common/windows/cpp/include/keymanversion.h"
  25: #include "../../../common/windows/cpp/include/legacy_kmx_memory.h"
  26: #include "../../../common/windows/cpp/include/legacy_kmx_file.h"

developer\src\kmdecomp\savekeyboard.cpp:
  34: #include "../../../common/windows/cpp/include/legacy_kmx_file.h"
  35: #include "../../../common/windows/cpp/include/legacy_kmx_memory.h"
  36: #include "../../../common/windows/cpp/include/vkeys.h"

developer\src\kmdecomp\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\samples\imsample\version.rc:
  1: #include "../../../../common/windows/cpp/include/keymanversion.h"

developer\src\setup\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"

developer\src\tike\version.rc:
  1: #include "../../../common/windows/cpp/include/keymanversion.h"