Skip to content

chore(common/models): lmworker-internal unit tests should report with TC integration #7294

@jahorton

Description

@jahorton

Describe the bug
The good news: #7215 did reconnect some previously-unconnected unit tests for common/models/templates and common/models/wordbreakers. (Also for common/models/types, except that one's a shell-script test, not a mocha-based test.

The bad news: the previously-disconnected tests aren't using the right "reporter", so TC doesn't know how to list their results correctly (or report them as part of the GitHub check text).

image

That nice checkmarked list of test results uses mocha's default reporter. Great for reports about local test runs, less great for CI integration:

image

Any checkmarked unit tests are not included in the tabulation shown at the level seen above. That is the issue.

Granted, if they fail, the build will fail - that won't be silent, fortunately. Still, it'd be more useful if they reported data about the failures at the top level when inspecting the build, rather than requiring a build-log dive.

Something custom to accomplish the same for the common/models/types "unit test" would be nice, too.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions