DEVELOPMENT tier workflow with KeymanHosts?

[darcywong00]

Currently, the DEVELOPMENT tier in KeymanHosts changes nearly all Keyman site links to http://host.docker.internal:{port}.

shared-sites/_common/KeymanHosts.php

Lines 134 to 142 in c7586ec

	} else if($this->tier == KeymanHosts::TIER_DEVELOPMENT) {
	// Locally running sites via Docker need to access "host.docker.internal:[port]"
	$this->s_keyman_com = "http://host.docker.internal:8054";
	$this->api_keyman_com = "http://host.docker.internal:8058";
	$this->help_keyman_com = "http://host.docker.internal:8055";
	$this->downloads_keyman_com = "https://downloads.keyman.com"; // local dev domain is usually not available
	$this->keyman_com = "http://host.docker.internal:8053";
	$this->keymanweb_com = "http://host.docker.internal:8057";
	$this->r_keymanweb_com = "https://r.keymanweb.com"; /// local dev domain is usually not available

Is there a workaround for when I'm only running one site locally on docker, and would rather the external Keyman sites use live links?

[mcdurdin]

This is tricky to solve. There are backend and frontend considerations. Perhaps links should automatically point to live sites by default, unless docker images are present. But that could mask API problems in your test environment, because it'd look like things are working correctly but it'd be because it'd be silently connecting to the frontend instead. (I've had this problem in the past.)

So ... not sure how best to address this.

[darcywong00]

This can be deferred. I can just hand-edit KeymanHosts for now

[darcywong00]

          I think LGTM. Can we rely on having website-local-proxy always running and use the same pattern for all the host.docker.internal references? That would avoid a lot of the confusion!

One challenge -- if we run the website-local-proxy on a port other than 80/443

Originally posted by @mcdurdin in #10 (review)

[ermshiperete]

Could we use environment variables that are passed to Docker to override some values? If a value is not specified then the defaults are used, otherwise the value from the env.