Skip to content

refactor: setAccessible no longer effect since PHP 8.1 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddevsr wants to merge 2 commits into from
Closed

refactor: setAccessible no longer effect since PHP 8.1 #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71490e0
refactor: setAccessible no longer effect since PHP 8.1
ddevsr Aug 15, 2025
ad382b5
Build
jnvsor Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified build/kint.phar
View file
Open in desktop
Binary file not shown.
4 changes: 3 additions & 1 deletion src/Parser/ClassStaticsPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ private function buildStaticValue(ReflectionProperty $pr, int $depth): AbstractV
$context->access_path = '\\'.$context->owner_class.'::$'.$context->name;
}

$pr->setAccessible(true);
if (KINT_PHP81 === false) {
$pr->setAccessible(true);
}

/**
* @psalm-suppress TooFewArguments
Expand Down
5 changes: 4 additions & 1 deletion src/Parser/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,10 @@ private function parseObject(object &$var, ContextInterface $c): AbstractValue
$properties = [];

foreach ($props as $rprop) {
$rprop->setAccessible(true);
if (KINT_PHP81 === false) {
$rprop->setAccessible(true);
}

$name = $rprop->getName();

// Casting object to array:
Expand Down
17 changes: 14 additions & 3 deletions tests/Parser/ClassStringsPluginTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,28 @@ public function testConstruct()

$reflector = new ReflectionClass($d);
$mprop = $reflector->getProperty('methods_plugin');
$mprop->setAccessible(true);

if (KINT_PHP81 === false) {
$mprop->setAccessible(true);
}

$m = $mprop->getValue($d);
$this->assertInstanceOf(ClassMethodsPlugin::class, $m);
$sprop = $reflector->getProperty('statics_plugin');
$sprop->setAccessible(true);

if (KINT_PHP81 === false) {
$sprop->setAccessible(true);
}

$s = $sprop->getValue($d);
$this->assertInstanceOf(ClassStaticsPlugin::class, $s);

$reflector = new ReflectionClass(AbstractPlugin::class);
$aparser = $reflector->getProperty('parser');
$aparser->setAccessible(true);

if (KINT_PHP81 === false) {
$aparser->setAccessible(true);
}

$p = new Parser();
$this->assertNotSame($p, $aparser->getValue($m));
Expand Down
17 changes: 14 additions & 3 deletions tests/Parser/DomPluginTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,28 @@ public function testConstruct()

$reflector = new ReflectionClass($d);
$mprop = $reflector->getProperty('methods_plugin');
$mprop->setAccessible(true);

if (KINT_PHP81 === false) {
$mprop->setAccessible(true);
}

$m = $mprop->getValue($d);
$this->assertInstanceOf(ClassMethodsPlugin::class, $m);
$sprop = $reflector->getProperty('statics_plugin');
$sprop->setAccessible(true);

if (KINT_PHP81 === false) {
$sprop->setAccessible(true);
}

$s = $sprop->getValue($d);
$this->assertInstanceOf(ClassStaticsPlugin::class, $s);

$reflector = new ReflectionClass(AbstractPlugin::class);
$aparser = $reflector->getProperty('parser');
$aparser->setAccessible(true);

if (KINT_PHP81 === false) {
$aparser->setAccessible(true);
}

$p = new Parser();
$this->assertNotSame($p, $aparser->getValue($m));
Expand Down
11 changes: 9 additions & 2 deletions tests/Parser/SimpleXMLElementPluginTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,20 @@ public function testConstruct()

$reflector = new ReflectionClass($s);
$mprop = $reflector->getProperty('methods_plugin');
$mprop->setAccessible(true);

if (KINT_PHP81 === false) {
$mprop->setAccessible(true);
}

$m = $mprop->getValue($s);
$this->assertInstanceOf(ClassMethodsPlugin::class, $m);

$reflector = new ReflectionClass(AbstractPlugin::class);
$mparser = $reflector->getProperty('parser');
$mparser->setAccessible(true);

if (KINT_PHP81 === false) {
$mparser->setAccessible(true);
}

$p = new Parser();
$this->assertNotSame($p, $mparser->getValue($m));
Expand Down
Loading