Skip to content

Fix tsserver protocol parser for TypeScript 5.9.3 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurfiorette merged 3 commits into from
Jan 22, 2026
Merged

Fix tsserver protocol parser for TypeScript 5.9.3 #455

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eab0e87
Initial plan
Copilot Jan 21, 2026
f96afdb
Fix TypeScript 5.9.3 protocol parsing in ts-html-plugin tests
Copilot Jan 21, 2026
eff90c9
Refactor message processing into separate method for better code quality
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 47 additions & 20 deletions packages/ts-html-plugin/test/util/lang-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export class TSLangServer {
isClosed = false;
server: ChildProcess;
sequence = 0;
buffer = ''; // Add buffer for incomplete messages

constructor(
projectPath: string,
Expand All @@ -86,32 +87,58 @@ export class TSLangServer {

this.server.stdout?.on('data', (data) => {
try {
const obj = JSON.parse(data.split('\n', 3)[2]);

if (this.debug) {
console.dir(obj, { depth: 10 });
}

if (obj.success === false) {
this.errorEmitter.emit(obj.type === 'event' ? obj.event : obj.command, obj);

// Error is fatal, close the server
if (!this.isClosed) {
this.isClosed = true;
this.server.stdin?.end();
}
} else if (obj.type === 'event') {
this.responseEventEmitter.emit(obj.event, obj);
} else if (obj.type === 'response') {
this.responseCommandEmitter.emit(obj.command, obj);
}
this.buffer += data;
this.#processMessages();
} catch (error) {
console.error(data);
console.error(this.buffer);
this.exitPromise.reject(error);
}
});
}

#processMessages() {
// Process all complete messages in the buffer
let headerMatch = this.buffer.match(/Content-Length: (\d+)\r?\n\r?\n/);

while (headerMatch && headerMatch.index !== undefined) {
// TSServer protocol: Content-Length: N\r\n\r\n{JSON}\r\n
const contentLength = parseInt(headerMatch[1], 10);
const headerEnd = headerMatch.index + headerMatch[0].length;
const messageEnd = headerEnd + contentLength;

// Check if we have the complete message
if (this.buffer.length < messageEnd) break;

// Extract and parse the message
const jsonStr = this.buffer.substring(headerEnd, messageEnd);
const obj = JSON.parse(jsonStr);

// Remove the processed message from buffer
this.buffer = this.buffer.substring(messageEnd);

if (this.debug) {
console.dir(obj, { depth: 10 });
}

if (obj.success === false) {
this.errorEmitter.emit(obj.type === 'event' ? obj.event : obj.command, obj);

// Error is fatal, close the server
if (!this.isClosed) {
this.isClosed = true;
this.server.stdin?.end();
}
} else if (obj.type === 'event') {
this.responseEventEmitter.emit(obj.event, obj);
} else if (obj.type === 'response') {
this.responseCommandEmitter.emit(obj.command, obj);
}

// Check for next message
headerMatch = this.buffer.match(/Content-Length: (\d+)\r?\n\r?\n/);
}
}

/** Opens the project, sends diagnostics request and returns the response */
async openWithDiagnostics(content: TemplateStringsArray, ...args: any[]) {
const fileContent = `${TEST_HELPERS}\n${String.raw(content, ...args).trim()}`;
Expand Down
Loading