From 3a88f0cbd528a536f60fee1f6a0980ead0176e11 Mon Sep 17 00:00:00 2001 From: Kaleb Barrett Date: Mon, 2 Jun 2025 15:26:52 -0600 Subject: [PATCH 1/2] Fail CI if coverage upload failure --- .github/workflows/tests.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2dcc0bd..962ef26 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -36,7 +36,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true setup-python: name: ${{ matrix.os }}-setup-python @@ -60,7 +60,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true anaconda: name: ${{ matrix.os }}-anaconda @@ -87,7 +87,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true rhel8-system-python: name: rhel8-system-python @@ -105,7 +105,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true rhel8-appstream-py38: name: rhel8-appstream-py38 @@ -123,7 +123,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true rhel8-appstream-py39: name: rhel8-appstream-py39 @@ -141,7 +141,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true rhel9-system-python: name: rhel9-system-python @@ -159,7 +159,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true msys: name: ${{ matrix.msystem }}-system-python @@ -196,7 +196,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true alpine: name: alpine-system-python @@ -220,7 +220,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true homebrew: name: homebrew-system-python @@ -246,7 +246,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true archlinux: name: archlinux-system-python @@ -275,7 +275,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - verbose: true + fail_ci_if_error: true concurrency: group: ${{ github.workflow }}-${{ github.ref }} From f26ef67493b922254195321a8f250d6998e9ef46 Mon Sep 17 00:00:00 2001 From: Kaleb Barrett Date: Mon, 2 Jun 2025 15:27:58 -0600 Subject: [PATCH 2/2] sidestep coverage collection issues on RHEL8 --- .github/workflows/tests.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 962ef26..5f9b654 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -101,11 +101,11 @@ jobs: run: python3 -m pip install nox - name: Run Tests run: python3 -m nox -e tests - - name: Upload to codecov - uses: codecov/codecov-action@v5 - with: - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true + # - name: Upload to codecov + # uses: codecov/codecov-action@v5 + # with: + # token: ${{ secrets.CODECOV_TOKEN }} + # fail_ci_if_error: true rhel8-appstream-py38: name: rhel8-appstream-py38 @@ -119,11 +119,11 @@ jobs: run: python3.8 -m pip install nox - name: Run Tests run: python3.8 -m nox -e tests - - name: Upload to codecov - uses: codecov/codecov-action@v5 - with: - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true + # - name: Upload to codecov + # uses: codecov/codecov-action@v5 + # with: + # token: ${{ secrets.CODECOV_TOKEN }} + # fail_ci_if_error: true rhel8-appstream-py39: name: rhel8-appstream-py39 @@ -137,11 +137,11 @@ jobs: run: python3.9 -m pip install nox - name: Run Tests run: python3.9 -m nox -e tests - - name: Upload to codecov - uses: codecov/codecov-action@v5 - with: - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true + # - name: Upload to codecov + # uses: codecov/codecov-action@v5 + # with: + # token: ${{ secrets.CODECOV_TOKEN }} + # fail_ci_if_error: true rhel9-system-python: name: rhel9-system-python