Why was the homebrew version bumped?

[willhama]

@cboulay hey there. Why was the version bumped on Homebrew? Any fallback options to the previous version 1.16.2? It broke my CICD :)

[cboulay]

There's a kinda important bug fix in the new version.

Let's get your CICD working again. What repo is it?

[willhama]

@cboulay hello there. We are using Rust LSL high-level bindings from: the https://github.com/labstreaminglayer/liblsl-rust.

If we are lucky, we could get the support from: @chkothe, since he wrote the liblsl-rust.

[cboulay]

Sorry, I'm confused. Why does bumping the homebrew formula affect an app that uses liblsl-rust? I haven't used liblsl-rust before, but looking through its structure, I don't see where it's calling brew. In fact, it has a specific version of liblsl pinned as a submodule within the lsl-sys folder.

[willhama]

@cboulay Sorry for the confusion. It was my mistake; we had some compatibility issues while building locally with cmake so we linked it with this PR against the system's Homebrew library: labstreaminglayer/liblsl-rust#12. Since we were using this branch and bundling it into a shippable binary, I used brew to install the library and then used the installed liblsl and bundled it with the binary (tauri framework). I fixed it now by dedicatelly build it with cmake and it works. No changes required from your side.

[cboulay]

OK thanks for following up.

Other than the bug fix I referenced above, the major change from 1.16 to 1.17 is in the CMake scripts and CI/CD. Also note that on MacOS we're publishing a framework, not a dylib, which cmake finds without issue but may cause problems if you're using hardcoded paths.
If you were to update this repo's liblsl submodule ref from the 1.16 tag to the 1.17.4 tag, then this might take care of a lot of your prior problems so you won't have to maintain a custom workflow. And if that doesn't do the trick, I'd like to know what the problem is so I can fix it.

Also, please let me know if there's any benefit to releasing a signed & notarized liblsl-rust binary. Typically there's no benefit to signing libraries themselves because the app developer has to sign the app anyway, but there can be benefit if e.g. the library is 'installed' like we now do with lsl.framework's "pkg" installer.