Skip to content

review #1 #6

@darkdarkdragon

Description

@darkdarkdragon

Here

s.records = sync.Map{}

is data race.
Here
msgChan <- StreamMessage{consumerCtx, message}

it can write to msgChan after it was closed here

Here

return record.LastStatus, nil

and here
status := record.LastStatus

LastStatus being copied not under the lock.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions