Localized URL for root pages seems broken

[greystate]

Hi there 👋

I seem to have hit a bug, using this package.

When a rootnode has multiple hostnames assigned, each with their own language, getting their URL doesn't work correctly...

Example

• One root node with two languages, English (US) and Danish
• One has example.com set as hostname, the other has example.com/da - each with their own language

When trying to render a language picker, we no longer get the correct URLs for the root node; e.g. Model.Root().Url("da") and Model.Root().Url("en-us") returns the same URL (/ or https://example.com/ if using UrlMode.Absolute)

If I uninstall InvisibleNodes, the URLs are correctly rendered.

Note

The URLs render correctly in the Links area on Umbraco's Info tab

I'm using Umbraco v13.3.1 and your latest (at time of writing) package release, v2.0.1

Thanks 🙌

[greystate]

Another note after some more testing - if the hostnames are different (e.g. by TLD or otherwise) it does seem to work correctly; so only when using the "one-level paths" version does your package seem to get the wrong idea.

[ljfio]

Hey @greystate, thanks for taking the time to raise this issue! You're certainly putting the package through its paces. Sorry I haven't been able to get round to this sooner.

I think I might have an idea what's going on here, will take a look and hopefully report back with some good news.

[ljfio]

Hey @greystate, I have just released v2.0.2 of the package.
Are you able to try that out and let me know if this resolves the issue?

[greystate]

Hi @ljfio — I don't think it does; I get an error when I try to publish the root node when I've added the current domain and one more using the subdirectory approach - e.g.:

• English (US): https://localhost:12345
• Danish: https://localhost:12345/da

This is the error I get:

--

Using different domains seems to work as expected (i.e. example.org and example.dk)

/Chriztian

[ljfio]

I released a new version v2.0.3 which I think resolves this exception being thrown. It wasn't something I had picked up in testing. Can you give that version a go and let me know?

If not would you be able to tell me if there's any additional information about the root node I might find useful (e.g. "varies by culture", have renamed the node previously, has a URL redirect).

[greystate]

@ljfio It looks like that did the trick 👍 Thanks again for sticking with it 🙌

Looks like I spoke too soon, sorry! I only tested the root URLs, but now I've added a pageFolder document type and configured it to be invisible and then there's problems again.

I'll try to set up a minimal test for you later today.

[ljfio]

Hey @greystate, sorry I hadn't followed up on this sooner. Did you get a chance to pull together some details around what you were seeing after the latest release?

[greystate]

Sorry @ljfio - never got around to it, and now it's vacation time, so will be a few weeks probably...

[ljfio]

@greystate There's a new version 2.0.6 which I think fixes a number of issues with the URL generation for multi domains / cultures. Are you able to take a look at the package again and see if it resolves your issue?

[greystate]

Hey @ljfio — yes, I should be able to test it over the weekend - thanks! 🙌

[ljfio]

Hey @greystate did you ever get a chance to test this?
There's now a version 13 package and a couple beta versions for 15 and 16.
I think my test suite should cover off the specific scenario you had.

[greystate]

Hey @ljfio — w00t, it's been so long already 😅

Well, we had to use another approach for the client, and never got back to trying this; I'll do my very best to try the new version out for our scenario very soon, and give you a thumbs up if it "just works".

Thanks 🙌