make error

[wchorski]

Not sure what to fix from this make error

pkg2zip on  master via  v11.4.0-gcc via  v3.10.12 
on Linux Mint ➜ make
[C] pkg2zip.c
In file included from /usr/include/string.h:535,
                 from miniz_tdef.h:5,
                 from pkg2zip_zip.h:5,
                 from pkg2zip.c:2:
In function ‘memset’,
    inlined from ‘find_pbp_sfo’ at pkg2zip.c:259:5,
    inlined from ‘main’ at pkg2zip.c:671:9:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: error: ‘__builtin___memset_chk’ forming offset [10, 15] is out of the bounds [0, 10] of object ‘discid’ with type ‘char[10]’ [-Werror=array-bounds]
   59 |   return __builtin___memset_chk (__dest, __ch, __len,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
pkg2zip.c: In function ‘main’:
pkg2zip.c:647:10: note: ‘discid’ declared here
  647 |     char discid[10];
      |          ^~~~~~
In file included from /usr/include/string.h:535,
                 from miniz_tdef.h:5,
                 from pkg2zip_zip.h:5,
                 from pkg2zip.c:2:
In function ‘memset’,
    inlined from ‘find_pbp_sfo’ at pkg2zip.c:259:5,
    inlined from ‘main’ at pkg2zip.c:671:9:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: error: ‘__builtin___memset_chk’ forming offset [10, 15] is out of the bounds [0, 10] of object ‘discid’ with type ‘char[10]’ [-Werror=array-bounds]
   59 |   return __builtin___memset_chk (__dest, __ch, __len,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
pkg2zip.c: In function ‘main’:
pkg2zip.c:647:10: note: ‘discid’ declared here
  647 |     char discid[10];
      |          ^~~~~~
cc1: all warnings being treated as errors
make: *** [makefile:57: pkg2zip.o] Error 1

---

             ...-:::::-...                 spearmint@spearmint 
          .-MMMMMMMMMMMMMMM-.              ------------------- 
      .-MMMM`..-:::::::-..`MMMM-.          OS: Linux Mint 21.3 x86_64 
    .:MMMM.:MMMMMMMMMMMMMMM:.MMMM:.        Host: A520 AORUS ELITE 
   -MMM-M---MMMMMMMMMMMMMMMMMMM.MMM-       Kernel: 5.15.0-124-generic 
 `:MMM:MM`  :MMMM:....::-...-MMMM:MMM:`    Uptime: 1 day, 12 hours, 33 mins 
 :MMM:MMM`  :MM:`  ``    ``  `:MMM:MMM:    Packages: 2942 (dpkg), 43 (flatpak) 
.MMM.MMMM`  :MM.  -MM.  .MM-  `MMMM.MMM.   Shell: bash 5.1.16 
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM-MMM:   Resolution: 1920x1080 
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM:MMM:   DE: Cinnamon 6.0.4 
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM-MMM:   WM: Mutter (Muffin) 
.MMM.MMMM`  :MM:--:MM:--:MM:  `MMMM.MMM.   WM Theme: Mint-Y-Dark-Teal (Mint-Y) 
 :MMM:MMM-  `-MMMMMMMMMMMM-`  -MMM-MMM:    Theme: Mint-Y-Dark-Teal [GTK2/3] 
  :MMM:MMM:`                `:MMM:MMM:     Icons: Mint-Y-Dark-Teal [GTK2/3] 
   .MMM.MMMM:--------------:MMMM.MMM.      Terminal: gnome-terminal 
     '-MMMM.-MMMMMMMMMMMMMMM-.MMMM-'       CPU: AMD Ryzen 9 3900X (24) @ 3.800GHz 
       '.-MMMM``--:::::--``MMMM-.'         GPU: NVIDIA GeForce GTX 1070 
            '-MMMMMMMMMMMMM-'              Memory: 14309MiB / 32010MiB 
               ``-:::::-``

[emertonom]

Looks like the find_pbp_sfo function tries to write 16 bites into a 10-byte array.

I'm not bothering to look into what the best way to fix this is, but I can give you a way that is adequate for it to compile, which is to change line 647 from

char discid[10];

to

char discid[16];

This way the memset call in find_pbp_sfo won't write past the end of the array. It's possible the discid field really is meant to be only 10 bytes, in which case it might be better to change line 259 from

memset(discid, 0x00, 0x10);

to

memset(discid, 0x00, 0x0A);

But at a guess I'd say making the array larger is marginally less likely to break things.