chore: rubocop

Author: ronaldtse

.rubocop_todo.yml

@@ -1,76 +1,211 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-12-01 12:13:26 UTC using RuboCop version 1.81.7.
+# on 2025-12-01 12:15:10 UTC using RuboCop version 1.81.7.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation.
+Bundler/OrderedGems:
+  Exclude:
+    - 'Gemfile'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterMagicComment:
+# Configuration parameters: Severity.
+Gemspec/RequireMFA:
   Exclude:
-    - 'lib/genericode/namespace.rb'
+    - 'genericode.gemspec'
 
 # Offense count: 1
+# Configuration parameters: Severity.
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'genericode.gemspec'
+
+# Offense count: 36
 # This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLinesAfterModuleInclusion:
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_argument, with_fixed_indentation
+Layout/ArgumentAlignment:
   Exclude:
-    - 'lib/genericode/code_list_set_ref.rb'
+    - 'lib/genericode/cli/code_lister.rb'
+    - 'lib/genericode/cli/commands.rb'
+    - 'lib/genericode/cli/converter.rb'
+    - 'lib/genericode/cli/validator.rb'
+    - 'lib/genericode/identification.rb'
+    - 'spec/genericode/cli/code_lookup_spec.rb'
+    - 'spec/genericode/cli/commands_spec.rb'
+    - 'spec/genericode/cli/converter_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingEmptyLines:
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_element, with_fixed_indentation
+Layout/ArrayAlignment:
   Exclude:
-    - 'lib/genericode/cli/code_lister.rb'
-    - 'lib/genericode/namespace.rb'
+    - 'genericode.gemspec'
+    - 'lib/genericode/cli/converter.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: IndentationWidth.
+Layout/AssignmentIndentation:
+  Exclude:
+    - 'lib/genericode/agency.rb'
+    - 'lib/genericode/identification.rb'
+
+# Offense count: 18
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleAlignWith.
+# SupportedStylesAlignWith: either, start_of_block, start_of_line
+Layout/BlockAlignment:
+  Exclude:
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/key.rb'
+    - 'spec/genericode/cli/commands_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
     - 'spec/genericode_spec.rb'
 
+# Offense count: 18
+# This cop supports safe autocorrection (--autocorrect).
+Layout/BlockEndNewline:
+  Exclude:
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/key.rb'
+    - 'spec/genericode/cli/commands_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
+    - 'spec/genericode_spec.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Layout/ClosingParenthesisIndentation:
+  Exclude:
+    - 'spec/genericode/cli/commands_spec.rb'
+
 # Offense count: 1
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
-Lint/DuplicateBranch:
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/genericode/cli/converter.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
+Layout/FirstArgumentIndentation:
   Exclude:
+    - 'spec/genericode/cli/commands_spec.rb'
+
+# Offense count: 42
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'genericode.gemspec'
+    - 'lib/genericode/agency.rb'
+    - 'lib/genericode/cli/commands.rb'
     - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/code_list_ref.rb'
+    - 'lib/genericode/code_list_set.rb'
+    - 'lib/genericode/code_list_set_ref.rb'
+    - 'lib/genericode/column.rb'
+    - 'lib/genericode/datatype_facet.rb'
+    - 'lib/genericode/identification.rb'
+    - 'lib/genericode/key.rb'
+    - 'spec/genericode/code_list_spec.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CheckForMethodsWithNoSideEffects.
-Lint/Void:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: normal, indented_internal_methods
+Layout/IndentationConsistency:
+  Exclude:
+    - 'genericode.gemspec'
+
+# Offense count: 36
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Width, AllowedPatterns.
+Layout/IndentationWidth:
   Exclude:
     - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/key.rb'
+    - 'spec/genericode/cli/commands_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
+    - 'spec/genericode_spec.rb'
 
-# Offense count: 8
-# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
-Metrics/AbcSize:
-  Max: 182
+# Offense count: 153
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# URISchemes: http, https
+Layout/LineLength:
+  Enabled: false
 
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
-# AllowedMethods: refine
-Metrics/BlockLength:
-  Max: 34
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: symmetrical, new_line, same_line
+Layout/MultilineMethodCallBraceLayout:
+  Exclude:
+    - 'spec/genericode/cli/commands_spec.rb'
+
+# Offense count: 60
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
+  Enabled: false
 
 # Offense count: 1
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 216
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches, IgnoreDuplicateElseBranch.
+Lint/DuplicateBranch:
+  Exclude:
+    - 'lib/genericode/code_list.rb'
 
-# Offense count: 6
-# Configuration parameters: AllowedMethods, AllowedPatterns.
+# Offense count: 11
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
+Metrics/AbcSize:
+  Exclude:
+    - 'lib/genericode/cli/code_lister.rb'
+    - 'lib/genericode/cli/commands.rb'
+    - 'lib/genericode/cli/validator.rb'
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/code_list_set.rb'
+    - 'spec/genericode_spec.rb'
+
+# Offense count: 7
+# Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
-  Max: 92
+  Exclude:
+    - 'lib/genericode/cli/code_lister.rb'
+    - 'lib/genericode/cli/validator.rb'
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/code_list_set.rb'
 
-# Offense count: 9
+# Offense count: 10
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 86
+  Max: 112
 
-# Offense count: 3
-# Configuration parameters: AllowedMethods, AllowedPatterns.
+# Offense count: 8
+# Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
-  Max: 92
+  Exclude:
+    - 'lib/genericode/cli/code_lister.rb'
+    - 'lib/genericode/cli/commands.rb'
+    - 'lib/genericode/cli/validator.rb'
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/code_list_set.rb'
 
 # Offense count: 2
 # Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
@@ -81,24 +216,106 @@ Naming/PredicateMethod:
     - 'lib/genericode/cli/converter.rb'
     - 'lib/genericode/cli/validator.rb'
 
-# Offense count: 1
+# Offense count: 2
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/genericode/cli/converter_spec.rb'
+
+# Offense count: 17
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
+# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
   Exclude:
-    - '**/*.arb'
-    - 'lib/genericode/namespace.rb'
+    - 'spec/genericode/cli/code_lister_spec.rb'
+    - 'spec/genericode/cli/code_lookup_spec.rb'
+    - 'spec/genericode/cli/converter_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+
+# Offense count: 17
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 23
+
+# Offense count: 2
+RSpec/LeakyLocalVariable:
+  Exclude:
+    - 'spec/genericode/code_list_spec.rb'
 
 # Offense count: 1
+RSpec/MultipleExpectations:
+  Max: 3
+
+# Offense count: 2
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/genericode_spec.rb'
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/ReceiveMessages:
+  Exclude:
+    - 'spec/genericode/cli/validator_spec.rb'
+
+# Offense count: 30
 # This cop supports safe autocorrection (--autocorrect).
-Style/IfUnlessModifier:
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# AllowedMethods: lambda, proc, it
+Style/BlockDelimiters:
   Exclude:
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/key.rb'
+    - 'spec/genericode/cli/commands_spec.rb'
+    - 'spec/genericode/cli/validator_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
     - 'spec/genericode_spec.rb'
 
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+Style/MultilineIfModifier:
+  Exclude:
+    - 'lib/genericode/cli/code_lister.rb'
+    - 'lib/genericode/cli/converter.rb'
+    - 'lib/genericode/cli/validator.rb'
+    - 'lib/genericode/code_list_set.rb'
+
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 121
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'genericode.gemspec'
+
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
+Style/TrailingCommaInArguments:
+  Exclude:
+    - 'spec/genericode/cli/code_lister_spec.rb'
+    - 'spec/genericode/cli/code_lookup_spec.rb'
+    - 'spec/genericode/cli/converter_spec.rb'
+    - 'spec/genericode/code_list_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
+  Exclude:
+    - 'lib/genericode/code_list.rb'
+
+# Offense count: 11
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
+Style/TrailingCommaInHashLiteral:
+  Exclude:
+    - 'lib/genericode/code_list.rb'
+    - 'lib/genericode/identification.rb'

Gemfile

@@ -12,6 +12,6 @@ gem "openssl"
 gem "rake"
 gem "rspec"
 gem "rubocop"
+gem "rubocop-performance"
 gem "rubocop-rake"
 gem "rubocop-rspec"
-gem "rubocop-performance"

genericode.gemspec

@@ -16,12 +16,15 @@ Gem::Specification.new do |spec|
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
   spec.metadata["changelog_uri"] = "https://github.com/lutaml/genericode/releases"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   gemspec = File.basename(__FILE__)
-  spec.files = IO.popen(%w[git ls-files -z], chdir: __dir__, err: IO::NULL) do |ls|
+  spec.files = IO.popen(%w[git ls-files -z], chdir: __dir__,
+                                             err: IO::NULL) do |ls|
     ls.readlines("\x0", chomp: true).reject do |f|
       (f == gemspec) ||
-        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor Gemfile])
+        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor
+                          Gemfile])
     end
   end
   spec.bindir = "exe"