Skip to content

Adds link to 9 Code Smells of Preprocessor Use article #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derpoliuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds link to 9 Code Smells of Preprocessor Use article #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ Magic values should be avoided. If you do need to define a constant, it should b

Avoid `#define`s. Unless you're writing an actual macro. Then, by all means, go ahead.

@jonreid has good article about [why `#define` is a 'code smell'](http://qualitycoding.org/preprocessor/).

You may use Hungarian notation for implementation-level constants.

**For example:**
Expand Down